starred/jellyfin
1
0
Fork 0
mirror of https://github.com/jellyfin/jellyfin.git synced 2026-07-16 05:43:54 +03:00
Code Issues 822 Packages Projects Releases 17 Wiki Activity

[PR #14635] Fixed unit tests for UserManager #14054

New Issue
Open
opened 2026-02-07 07:23:37 +03:00 by OVERLORD · 0 comments
OVERLORD commented 2026-02-07 07:23:37 +03:00
Owner
Copy Link

📋 Pull Request Information

Original PR: https://github.com/jellyfin/jellyfin/pull/14635
Author: @iig1988
Created: 8/12/2025
Status: 🔄 Open

Base: master ← Head: fix-test

📝 Commits (1)

  • b73fef4 Fixed unit tests for UserManager

📊 Changes

7 files changed (+76 additions, -31 deletions)

View changed files

📝 Jellyfin.Api/Controllers/StartupController.cs (+5 -2)
📝 Jellyfin.Server.Implementations/Users/UserManager.cs (+7 -20)
➕ Jellyfin.Server.Implementations/Users/UserValidation.cs (+35 -0)
📝 Jellyfin.Server/CoreAppHost.cs (+1 -0)
📝 MediaBrowser.Controller/Library/IUserManager.cs (+0 -6)
➕ MediaBrowser.Controller/Library/IUserValidation.cs (+21 -0)
📝 tests/Jellyfin.Server.Implementations.Tests/Users/UserValidationTests.cs (+7 -3)

📄 Description

Hi!
I've updated the tests for UserManager. Specifically, I've moved the username validation to a separate UserValidation class.

🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/jellyfin/jellyfin/pull/14635 **Author:** [@iig1988](https://github.com/iig1988) **Created:** 8/12/2025 **Status:** 🔄 Open **Base:** `master` ← **Head:** `fix-test` --- ### 📝 Commits (1) - [`b73fef4`](https://github.com/jellyfin/jellyfin/commit/b73fef4075649556acabd25c67cf4ffd98c35188) Fixed unit tests for UserManager ### 📊 Changes **7 files changed** (+76 additions, -31 deletions) <details> <summary>View changed files</summary> 📝 `Jellyfin.Api/Controllers/StartupController.cs` (+5 -2) 📝 `Jellyfin.Server.Implementations/Users/UserManager.cs` (+7 -20) ➕ `Jellyfin.Server.Implementations/Users/UserValidation.cs` (+35 -0) 📝 `Jellyfin.Server/CoreAppHost.cs` (+1 -0) 📝 `MediaBrowser.Controller/Library/IUserManager.cs` (+0 -6) ➕ `MediaBrowser.Controller/Library/IUserValidation.cs` (+21 -0) 📝 `tests/Jellyfin.Server.Implementations.Tests/Users/UserValidationTests.cs` (+7 -3) </details> ### 📄 Description Hi! I've updated the tests for UserManager. Specifically, I've moved the username validation to a separate UserValidation class. --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
OVERLORD added the pull-request label 2026-02-07 07:23:37 +03:00
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
EFjellyfin.db
area:database
awaiting-feedback
backend
blocked
breaking change: web api
bug
build
ci
confirmed
discussion needed
dotnet future
downstream
duplicate
enhancement
feature
future
github-actions
good first issue
hdr
help wanted
invalid
investigation
librarydb
live-tv
lyrics
media playback
music
needs testing
nuget
performance
platform
pull-request
Mirrored from GitHub Pull Request
 question
regression
release critical
requires-web
roadmap
security
security
stale
support
syncplay
ui & ux
upstream
wontfix
No Label pull-request
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
OVERLORD
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: starred/jellyfin#14054
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?