starred/jellyfin
1
0
Fork 0
mirror of https://github.com/jellyfin/jellyfin.git synced 2026-07-16 05:43:54 +03:00
Code Issues 822 Packages Projects Releases 17 Wiki Activity

[PR #14461] [MERGED] Fix refreshing the library cannot delete old attachments #13994

New Issue
Closed
opened 2026-02-07 07:22:32 +03:00 by OVERLORD · 0 comments
OVERLORD commented 2026-02-07 07:22:32 +03:00
Owner
Copy Link

📋 Pull Request Information

Original PR: https://github.com/jellyfin/jellyfin/pull/14461
Author: @nyanmisaka
Created: 7/13/2025
Status: ✅ Merged
Merged: 7/15/2025
Merged by: @crobibero

Base: master ← Head: fix-attachments-refresh

📝 Commits (1)

  • b8ccc70 Fix refreshing the library cannot delete old attachments

📊 Changes

2 files changed (+10 additions, -5 deletions)

View changed files

📝 Jellyfin.Server.Implementations/Item/MediaAttachmentRepository.cs (+9 -1)
📝 MediaBrowser.Providers/MediaInfo/FFProbeVideoInfo.cs (+1 -4)

📄 Description

Changes

  • Fix refreshing the library cannot delete old attachments

Issues

  • A user replaced an MKV video from one that included embedded fonts to one that did not, causing SSA/ASS subtitle rendering on the web to fail because the old attachment information was not deleted from the database.
image

🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/jellyfin/jellyfin/pull/14461 **Author:** [@nyanmisaka](https://github.com/nyanmisaka) **Created:** 7/13/2025 **Status:** ✅ Merged **Merged:** 7/15/2025 **Merged by:** [@crobibero](https://github.com/crobibero) **Base:** `master` ← **Head:** `fix-attachments-refresh` --- ### 📝 Commits (1) - [`b8ccc70`](https://github.com/jellyfin/jellyfin/commit/b8ccc7055d96110423340fbd8a2f3b3541e63482) Fix refreshing the library cannot delete old attachments ### 📊 Changes **2 files changed** (+10 additions, -5 deletions) <details> <summary>View changed files</summary> 📝 `Jellyfin.Server.Implementations/Item/MediaAttachmentRepository.cs` (+9 -1) 📝 `MediaBrowser.Providers/MediaInfo/FFProbeVideoInfo.cs` (+1 -4) </details> ### 📄 Description **Changes** - Fix refreshing the library cannot delete old attachments **Issues** - A user replaced an MKV video from one that included embedded fonts to one that did not, causing SSA/ASS subtitle rendering on the web to fail because the old attachment information was not deleted from the database. <img width="1151" height="436" alt="image" src="https://github.com/user-attachments/assets/46290c9d-8449-4f5b-bb82-95ea268f3627" /> --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
OVERLORD added the pull-request label 2026-02-07 07:22:32 +03:00
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
EFjellyfin.db
area:database
awaiting-feedback
backend
blocked
breaking change: web api
bug
build
ci
confirmed
discussion needed
dotnet future
downstream
duplicate
enhancement
feature
future
github-actions
good first issue
hdr
help wanted
invalid
investigation
librarydb
live-tv
lyrics
media playback
music
needs testing
nuget
performance
platform
pull-request
Mirrored from GitHub Pull Request
 question
regression
release critical
requires-web
roadmap
security
security
stale
support
syncplay
ui & ux
upstream
wontfix
No Label pull-request
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
OVERLORD
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: starred/jellyfin#13994
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?