starred/jellyfin
1
0
Fork 0
mirror of https://github.com/jellyfin/jellyfin.git synced 2026-07-16 05:43:54 +03:00
Code Issues 822 Packages Projects Releases 17 Wiki Activity

[PR #14382] [CLOSED] Make server side evaluation of DTO parallel #13964

New Issue
Closed
opened 2026-02-07 07:22:03 +03:00 by OVERLORD · 0 comments
OVERLORD commented 2026-02-07 07:22:03 +03:00
Owner
Copy Link

📋 Pull Request Information

Original PR: https://github.com/jellyfin/jellyfin/pull/14382
Author: @JPVenson
Created: 6/26/2025
Status: ❌ Closed

Base: master ← Head: feature/fasterCollectionGet

📝 Commits (8)

  • a2154b9 Make server side evaluation of DTO parallel
  • 472a6b5 Use the Count instead of the full query
  • e3267e8 cleanup count queries
  • a1e9552 Cleanup more queries
  • 8028ba7 Revert user related query counting
  • 7a9d3cd Fix program add operations
  • b1d9f4c Fixed wrong user related queries
  • f41ed6b Readd missing parent

📊 Changes

6 files changed (+90 additions, -90 deletions)

View changed files

📝 Emby.Server.Implementations/Dto/DtoService.cs (+9 -8)
📝 Emby.Server.Implementations/ScheduledTasks/Tasks/ChapterImagesTask.cs (+2 -1)
📝 Jellyfin.Api/Controllers/LibraryController.cs (+18 -18)
📝 MediaBrowser.Controller/Entities/Folder.cs (+14 -16)
📝 MediaBrowser.Controller/Entities/InternalItemsQuery.cs (+34 -34)
📝 MediaBrowser.Controller/Entities/TV/Series.cs (+13 -13)

📄 Description

evaluates all properties added by the DTO creation in parallel to all requested items.

This is only a bandaid and will only help with performance on systems with adequate performance headroom but the alternative of rewriting all of the DTO creation so it can util all properties from the source query is a fundemental refactoring which cannot be done for 10.11.

Mitigates: #14336 , #14278 #14285 #14380

🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/jellyfin/jellyfin/pull/14382 **Author:** [@JPVenson](https://github.com/JPVenson) **Created:** 6/26/2025 **Status:** ❌ Closed **Base:** `master` ← **Head:** `feature/fasterCollectionGet` --- ### 📝 Commits (8) - [`a2154b9`](https://github.com/jellyfin/jellyfin/commit/a2154b95636d2eb0e2ee2db91127ba6d8f80fc73) Make server side evaluation of DTO parallel - [`472a6b5`](https://github.com/jellyfin/jellyfin/commit/472a6b59a85ef700319fdd4400f6a3effb0f656a) Use the Count instead of the full query - [`e3267e8`](https://github.com/jellyfin/jellyfin/commit/e3267e8bc88f71c77c1e45734961c235f7b2f97f) cleanup count queries - [`a1e9552`](https://github.com/jellyfin/jellyfin/commit/a1e955254d922018df50ef0791a3be6755e188ac) Cleanup more queries - [`8028ba7`](https://github.com/jellyfin/jellyfin/commit/8028ba779d91e680030b3d45bced449a45234b9e) Revert user related query counting - [`7a9d3cd`](https://github.com/jellyfin/jellyfin/commit/7a9d3cd362cf4af5aca0cc5f11183fa8add391f0) Fix program add operations - [`b1d9f4c`](https://github.com/jellyfin/jellyfin/commit/b1d9f4cbfd3de8b2f2bee7890e266008a18ab6b7) Fixed wrong user related queries - [`f41ed6b`](https://github.com/jellyfin/jellyfin/commit/f41ed6bae50077366d78b570e66ff676041bdef7) Readd missing parent ### 📊 Changes **6 files changed** (+90 additions, -90 deletions) <details> <summary>View changed files</summary> 📝 `Emby.Server.Implementations/Dto/DtoService.cs` (+9 -8) 📝 `Emby.Server.Implementations/ScheduledTasks/Tasks/ChapterImagesTask.cs` (+2 -1) 📝 `Jellyfin.Api/Controllers/LibraryController.cs` (+18 -18) 📝 `MediaBrowser.Controller/Entities/Folder.cs` (+14 -16) 📝 `MediaBrowser.Controller/Entities/InternalItemsQuery.cs` (+34 -34) 📝 `MediaBrowser.Controller/Entities/TV/Series.cs` (+13 -13) </details> ### 📄 Description evaluates all properties added by the DTO creation in parallel to all requested items. This is only a bandaid and will only help with performance on systems with adequate performance headroom but the alternative of rewriting all of the DTO creation so it can util all properties from the source query is a fundemental refactoring which cannot be done for 10.11. Mitigates: #14336 , #14278 #14285 #14380 --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
OVERLORD added the pull-request label 2026-02-07 07:22:03 +03:00
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
EFjellyfin.db
area:database
awaiting-feedback
backend
blocked
breaking change: web api
bug
build
ci
confirmed
discussion needed
dotnet future
downstream
duplicate
enhancement
feature
future
github-actions
good first issue
hdr
help wanted
invalid
investigation
librarydb
live-tv
lyrics
media playback
music
needs testing
nuget
performance
platform
pull-request
Mirrored from GitHub Pull Request
 question
regression
release critical
requires-web
roadmap
security
security
stale
support
syncplay
ui & ux
upstream
wontfix
No Label pull-request
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
OVERLORD
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: starred/jellyfin#13964
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?