starred/jellyfin
1
0
Fork 0
mirror of https://github.com/jellyfin/jellyfin.git synced 2026-07-16 05:43:54 +03:00
Code Issues 822 Packages Projects Releases 17 Wiki Activity

[PR #14360] [MERGED] Fix issue with syncplay group incorrectly playing content on creation #13952

New Issue
Closed
opened 2026-02-07 07:21:53 +03:00 by OVERLORD · 0 comments
OVERLORD commented 2026-02-07 07:21:53 +03:00
Owner
Copy Link

📋 Pull Request Information

Original PR: https://github.com/jellyfin/jellyfin/pull/14360
Author: @Mason-Weigand
Created: 6/21/2025
Status: ✅ Merged
Merged: 6/23/2025
Merged by: @crobibero

Base: master ← Head: fix-session-playingitem-desync

📝 Commits (1)

  • 5aa414e RemoveNowPlayingItem should also set FullNowPlayingItem to null

📊 Changes

1 file changed (+1 additions, -0 deletions)

View changed files

📝 Emby.Server.Implementations/Session/SessionManager.cs (+1 -0)

📄 Description

When a sync play group is created it is checking the sessions FullNowPlayingItem property to determine if it should start playback. This property wasn't being set when playback stopped for the session. Newly created groups would then automatically start playback on items that were no longer being played on the session.

Changes

Set FullNowPlayingItem to null in RemoveNowPlayingItem method to ensure FullNowPlayingItem and NowPlayingItem are kept in sync on item removal and groups don't see a stale value

🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/jellyfin/jellyfin/pull/14360 **Author:** [@Mason-Weigand](https://github.com/Mason-Weigand) **Created:** 6/21/2025 **Status:** ✅ Merged **Merged:** 6/23/2025 **Merged by:** [@crobibero](https://github.com/crobibero) **Base:** `master` ← **Head:** `fix-session-playingitem-desync` --- ### 📝 Commits (1) - [`5aa414e`](https://github.com/jellyfin/jellyfin/commit/5aa414e2e6e9001b199e328c4f45d91d8a56a8df) RemoveNowPlayingItem should also set FullNowPlayingItem to null ### 📊 Changes **1 file changed** (+1 additions, -0 deletions) <details> <summary>View changed files</summary> 📝 `Emby.Server.Implementations/Session/SessionManager.cs` (+1 -0) </details> ### 📄 Description When a sync play group is created it is checking the sessions `FullNowPlayingItem` property to determine if it should start playback. This property wasn't being set when playback stopped for the session. Newly created groups would then automatically start playback on items that were no longer being played on the session. **Changes** Set `FullNowPlayingItem` to null in `RemoveNowPlayingItem` method to ensure `FullNowPlayingItem` and `NowPlayingItem` are kept in sync on item removal and groups don't see a stale value --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
OVERLORD added the pull-request label 2026-02-07 07:21:53 +03:00
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
EFjellyfin.db
area:database
awaiting-feedback
backend
blocked
breaking change: web api
bug
build
ci
confirmed
discussion needed
dotnet future
downstream
duplicate
enhancement
feature
future
github-actions
good first issue
hdr
help wanted
invalid
investigation
librarydb
live-tv
lyrics
media playback
music
needs testing
nuget
performance
platform
pull-request
Mirrored from GitHub Pull Request
 question
regression
release critical
requires-web
roadmap
security
security
stale
support
syncplay
ui & ux
upstream
wontfix
No Label pull-request
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
OVERLORD
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: starred/jellyfin#13952
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?