starred/jellyfin
1
0
Fork 0
mirror of https://github.com/jellyfin/jellyfin.git synced 2026-05-04 18:09:12 +03:00
Code Issues 822 Packages Projects Releases 10 Wiki Activity

[PR #14347] [MERGED] Fix modification checks and make sure to use UTC #13950

New Issue
Closed
opened 2026-02-07 07:21:50 +03:00 by OVERLORD · 0 comments
OVERLORD commented 2026-02-07 07:21:50 +03:00
Owner
Copy Link

📋 Pull Request Information

Original PR: https://github.com/jellyfin/jellyfin/pull/14347
Author: @Shadowghost
Created: 6/19/2025
Status: ✅ Merged
Merged: 6/27/2025
Merged by: @crobibero

Base: master ← Head: misc2

📝 Commits (10+)

  • 0b21975 Fix modification checks and make sure to use UTC
  • 499c1d3 Set DateLastSaved after saving
  • 1765301 Remove unused variable
  • c952782 Only check DateLastSaved if not set to default
  • da25a0f Fix checks on non-UTC/ negative offset local time
  • 5195236 Fix timestamps in DB
  • 8f22a1b Fix logger
  • 1380bbb Fixes
  • cc21bb6 Only execute migration if not UTC
  • c551870 Fixup

📊 Changes

22 files changed (+1990 additions, -67 deletions)

View changed files

📝 Emby.Photos/PhotoProvider.cs (+1 -1)
📝 Emby.Server.Implementations/HttpServer/WebSocketConnection.cs (+1 -1)
📝 Emby.Server.Implementations/Images/BaseDynamicImageProvider.cs (+9 -5)
📝 Emby.Server.Implementations/Library/LibraryManager.cs (+16 -12)
📝 Emby.Server.Implementations/Library/ResolverHelper.cs (+1 -1)
📝 Emby.Server.Implementations/Plugins/PluginManager.cs (+1 -1)
📝 Emby.Server.Implementations/Sorting/StartDateComparer.cs (+0 -1)
📝 Jellyfin.Server.Implementations/Item/BaseItemRepository.cs (+13 -13)
➕ Jellyfin.Server/Migrations/Routines/FixDates.cs (+168 -0)
📝 MediaBrowser.Controller/Entities/BaseItem.cs (+4 -11)
📝 MediaBrowser.LocalMetadata/Savers/BaseXmlSaver.cs (+2 -2)
📝 MediaBrowser.Providers/Manager/MetadataService.cs (+6 -6)
📝 MediaBrowser.Providers/Manager/ProviderManager.cs (+8 -1)
📝 MediaBrowser.XbmcMetadata/Providers/BaseNfoProvider.cs (+1 -0)
📝 src/Jellyfin.Database/Jellyfin.Database.Implementations/Entities/BaseItemImageInfo.cs (+1 -1)
📝 src/Jellyfin.Database/Jellyfin.Database.Implementations/QueryPartitionHelpers.cs (+4 -4)
➕ src/Jellyfin.Database/Jellyfin.Database.Providers.Sqlite/Migrations/20250622170802_BaseItemImageInfoDateModifiedNullable.Designer.cs (+1709 -0)
➕ src/Jellyfin.Database/Jellyfin.Database.Providers.Sqlite/Migrations/20250622170802_BaseItemImageInfoDateModifiedNullable.cs (+37 -0)
📝 src/Jellyfin.Database/Jellyfin.Database.Providers.Sqlite/Migrations/JellyfinDbModelSnapshot.cs (+1 -1)
📝 src/Jellyfin.LiveTv/Channels/ChannelManager.cs (+1 -1)

...and 2 more files

📄 Description

Changes

  • Ensure we always save UTC time for DateModified and DateCreated
  • Simplify some checks

Issues
Fixes #14303
Fixes #14317

🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/jellyfin/jellyfin/pull/14347 **Author:** [@Shadowghost](https://github.com/Shadowghost) **Created:** 6/19/2025 **Status:** ✅ Merged **Merged:** 6/27/2025 **Merged by:** [@crobibero](https://github.com/crobibero) **Base:** `master` ← **Head:** `misc2` --- ### 📝 Commits (10+) - [`0b21975`](https://github.com/jellyfin/jellyfin/commit/0b2197526b49cbf57345f8d48dc973c14ee55d28) Fix modification checks and make sure to use UTC - [`499c1d3`](https://github.com/jellyfin/jellyfin/commit/499c1d31ff2ad71e1d3ed0e67d88a1602802b021) Set DateLastSaved after saving - [`1765301`](https://github.com/jellyfin/jellyfin/commit/1765301509628cb43fa4589ba2170c00deff9a19) Remove unused variable - [`c952782`](https://github.com/jellyfin/jellyfin/commit/c952782b92d61645dc40a5a7c8c20d524fc90812) Only check DateLastSaved if not set to default - [`da25a0f`](https://github.com/jellyfin/jellyfin/commit/da25a0fd45f4228666667295ee3ab7373cdb8aea) Fix checks on non-UTC/ negative offset local time - [`5195236`](https://github.com/jellyfin/jellyfin/commit/51952365db83e97eb264c55e32e51faedf179f52) Fix timestamps in DB - [`8f22a1b`](https://github.com/jellyfin/jellyfin/commit/8f22a1b9a397d8643b2a1f498cb5cdfdcba97da8) Fix logger - [`1380bbb`](https://github.com/jellyfin/jellyfin/commit/1380bbbbaea7a2046c90f58954780be79b95afe2) Fixes - [`cc21bb6`](https://github.com/jellyfin/jellyfin/commit/cc21bb636110a10e280baec15d6c9866c25cbf1b) Only execute migration if not UTC - [`c551870`](https://github.com/jellyfin/jellyfin/commit/c5518704b8136eb231ffb0037b109637b9e85659) Fixup ### 📊 Changes **22 files changed** (+1990 additions, -67 deletions) <details> <summary>View changed files</summary> 📝 `Emby.Photos/PhotoProvider.cs` (+1 -1) 📝 `Emby.Server.Implementations/HttpServer/WebSocketConnection.cs` (+1 -1) 📝 `Emby.Server.Implementations/Images/BaseDynamicImageProvider.cs` (+9 -5) 📝 `Emby.Server.Implementations/Library/LibraryManager.cs` (+16 -12) 📝 `Emby.Server.Implementations/Library/ResolverHelper.cs` (+1 -1) 📝 `Emby.Server.Implementations/Plugins/PluginManager.cs` (+1 -1) 📝 `Emby.Server.Implementations/Sorting/StartDateComparer.cs` (+0 -1) 📝 `Jellyfin.Server.Implementations/Item/BaseItemRepository.cs` (+13 -13) ➕ `Jellyfin.Server/Migrations/Routines/FixDates.cs` (+168 -0) 📝 `MediaBrowser.Controller/Entities/BaseItem.cs` (+4 -11) 📝 `MediaBrowser.LocalMetadata/Savers/BaseXmlSaver.cs` (+2 -2) 📝 `MediaBrowser.Providers/Manager/MetadataService.cs` (+6 -6) 📝 `MediaBrowser.Providers/Manager/ProviderManager.cs` (+8 -1) 📝 `MediaBrowser.XbmcMetadata/Providers/BaseNfoProvider.cs` (+1 -0) 📝 `src/Jellyfin.Database/Jellyfin.Database.Implementations/Entities/BaseItemImageInfo.cs` (+1 -1) 📝 `src/Jellyfin.Database/Jellyfin.Database.Implementations/QueryPartitionHelpers.cs` (+4 -4) ➕ `src/Jellyfin.Database/Jellyfin.Database.Providers.Sqlite/Migrations/20250622170802_BaseItemImageInfoDateModifiedNullable.Designer.cs` (+1709 -0) ➕ `src/Jellyfin.Database/Jellyfin.Database.Providers.Sqlite/Migrations/20250622170802_BaseItemImageInfoDateModifiedNullable.cs` (+37 -0) 📝 `src/Jellyfin.Database/Jellyfin.Database.Providers.Sqlite/Migrations/JellyfinDbModelSnapshot.cs` (+1 -1) 📝 `src/Jellyfin.LiveTv/Channels/ChannelManager.cs` (+1 -1) _...and 2 more files_ </details> ### 📄 Description **Changes** * Ensure we always save UTC time for `DateModified` and `DateCreated` * Simplify some checks **Issues** Fixes #14303 Fixes #14317 --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
OVERLORD added the pull-request label 2026-02-07 07:21:50 +03:00
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
EFjellyfin.db
area:database
awaiting-feedback
backend
blocked
breaking change: web api
bug
build
ci
confirmed
discussion needed
dotnet future
downstream
duplicate
enhancement
feature
future
github-actions
good first issue
hdr
help wanted
invalid
investigation
librarydb
live-tv
lyrics
media playback
music
needs testing
nuget
performance
platform
pull-request
Mirrored from GitHub Pull Request
 question
regression
release critical
requires-web
roadmap
security
security
stale
support
syncplay
ui & ux
upstream
wontfix
No Label pull-request
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
OVERLORD
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: starred/jellyfin#13950
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?