starred/jellyfin
1
0
Fork 0
mirror of https://github.com/jellyfin/jellyfin.git synced 2026-05-04 18:09:12 +03:00
Code Issues 822 Packages Projects Releases 10 Wiki Activity

[PR #14337] Fix metadata manager infinite loading when Live TV access is revoked #13945

New Issue
Open
opened 2026-02-07 07:21:46 +03:00 by OVERLORD · 0 comments
OVERLORD commented 2026-02-07 07:21:46 +03:00
Owner
Copy Link

📋 Pull Request Information

Original PR: https://github.com/jellyfin/jellyfin/pull/14337
Author: @evanqhuang
Created: 6/18/2025
Status: 🔄 Open

Base: master ← Head: edit-metadata-live-tv

📝 Commits (1)

  • 46003b6 Fix metadata manager infinite loading when Live TV access is revoked

📊 Changes

1 file changed (+18 additions, -2 deletions)

View changed files

📝 Jellyfin.Api/Controllers/LiveTvController.cs (+18 -2)

📄 Description

Resolves issue where the metadata manager would show infinite loading screen when users don't have Live TV access permissions. The problem was caused by 403 Forbidden errors from LiveTv/Channels and LiveTv/Recordings endpoints.

Changes- Remove [Authorize(Policy = Policies.LiveTvAccess)] from GetLiveTvChannels() and GetRecordings()

  • Add manual permission checks that return empty QueryResult instead of 403 errors
  • Check authenticated user permissions rather than target user permissions
  • Preserve security by validating PermissionKind.EnableLiveTvAccess

This allows the metadata manager to receive empty results gracefully instead of failing with 403 errors, preventing the infinite loading issue while maintaining proper authorization.

Issues
Fixes #9908

🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/jellyfin/jellyfin/pull/14337 **Author:** [@evanqhuang](https://github.com/evanqhuang) **Created:** 6/18/2025 **Status:** 🔄 Open **Base:** `master` ← **Head:** `edit-metadata-live-tv` --- ### 📝 Commits (1) - [`46003b6`](https://github.com/jellyfin/jellyfin/commit/46003b66b11650774c4707ada16fe2a3965805d1) Fix metadata manager infinite loading when Live TV access is revoked ### 📊 Changes **1 file changed** (+18 additions, -2 deletions) <details> <summary>View changed files</summary> 📝 `Jellyfin.Api/Controllers/LiveTvController.cs` (+18 -2) </details> ### 📄 Description Resolves issue where the metadata manager would show infinite loading screen when users don't have Live TV access permissions. The problem was caused by 403 Forbidden errors from LiveTv/Channels and LiveTv/Recordings endpoints. **Changes**- Remove [Authorize(Policy = Policies.LiveTvAccess)] from GetLiveTvChannels() and GetRecordings() - Add manual permission checks that return empty QueryResult instead of 403 errors - Check authenticated user permissions rather than target user permissions - Preserve security by validating PermissionKind.EnableLiveTvAccess This allows the metadata manager to receive empty results gracefully instead of failing with 403 errors, preventing the infinite loading issue while maintaining proper authorization. **Issues** Fixes #9908 --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
OVERLORD added the pull-request label 2026-02-07 07:21:46 +03:00
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
EFjellyfin.db
area:database
awaiting-feedback
backend
blocked
breaking change: web api
bug
build
ci
confirmed
discussion needed
dotnet future
downstream
duplicate
enhancement
feature
future
github-actions
good first issue
hdr
help wanted
invalid
investigation
librarydb
live-tv
lyrics
media playback
music
needs testing
nuget
performance
platform
pull-request
Mirrored from GitHub Pull Request
 question
regression
release critical
requires-web
roadmap
security
security
stale
support
syncplay
ui & ux
upstream
wontfix
No Label pull-request
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
OVERLORD
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: starred/jellyfin#13945
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?