starred/jellyfin
1
0
Fork 0
mirror of https://github.com/jellyfin/jellyfin.git synced 2026-07-16 05:43:54 +03:00
Code Issues 822 Packages Projects Releases 17 Wiki Activity

[PR #14284] [MERGED] Fix People Issues #13919

New Issue
Closed
opened 2026-02-07 07:21:20 +03:00 by OVERLORD · 0 comments
OVERLORD commented 2026-02-07 07:21:20 +03:00
Owner
Copy Link

📋 Pull Request Information

Original PR: https://github.com/jellyfin/jellyfin/pull/14284
Author: @Shadowghost
Created: 6/11/2025
Status: ✅ Merged
Merged: 6/12/2025
Merged by: @crobibero

Base: master ← Head: fix-music-people

📝 Commits (3)

  • e7d7084 Fix People association for Albums
  • 11adbef Skip person creation if internal metadata folder creation fails
  • 3599c3f Update Emby.Server.Implementations/Library/LibraryManager.cs

📊 Changes

3 files changed (+36 additions, -23 deletions)

View changed files

📝 Emby.Server.Implementations/Library/LibraryManager.cs (+22 -14)
📝 MediaBrowser.Providers/Manager/MetadataService.cs (+1 -2)
📝 MediaBrowser.Providers/Music/AlbumMetadataService.cs (+13 -7)

📄 Description

People need to be associated AFTER the item is created, otherwise foreign key issues happen.

Changes

  • Extract SetPeople to be run after saving instead of when updating metadata from children
  • Skip People creation if local metadata path creation fails

Issues
Fixes #14245
Fixes #14283

🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/jellyfin/jellyfin/pull/14284 **Author:** [@Shadowghost](https://github.com/Shadowghost) **Created:** 6/11/2025 **Status:** ✅ Merged **Merged:** 6/12/2025 **Merged by:** [@crobibero](https://github.com/crobibero) **Base:** `master` ← **Head:** `fix-music-people` --- ### 📝 Commits (3) - [`e7d7084`](https://github.com/jellyfin/jellyfin/commit/e7d7084276bf392432d5a6c67ea80de4dbd89b85) Fix People association for Albums - [`11adbef`](https://github.com/jellyfin/jellyfin/commit/11adbefe30906fab946274b725c286d071b09afa) Skip person creation if internal metadata folder creation fails - [`3599c3f`](https://github.com/jellyfin/jellyfin/commit/3599c3f8edfa80a3ae01c385e4c9daacc88be5b0) Update Emby.Server.Implementations/Library/LibraryManager.cs ### 📊 Changes **3 files changed** (+36 additions, -23 deletions) <details> <summary>View changed files</summary> 📝 `Emby.Server.Implementations/Library/LibraryManager.cs` (+22 -14) 📝 `MediaBrowser.Providers/Manager/MetadataService.cs` (+1 -2) 📝 `MediaBrowser.Providers/Music/AlbumMetadataService.cs` (+13 -7) </details> ### 📄 Description People need to be associated AFTER the item is created, otherwise foreign key issues happen. **Changes** * Extract `SetPeople` to be run after saving instead of when updating metadata from children * Skip People creation if local metadata path creation fails **Issues** Fixes #14245 Fixes #14283 --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
OVERLORD added the pull-request label 2026-02-07 07:21:20 +03:00
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
EFjellyfin.db
area:database
awaiting-feedback
backend
blocked
breaking change: web api
bug
build
ci
confirmed
discussion needed
dotnet future
downstream
duplicate
enhancement
feature
future
github-actions
good first issue
hdr
help wanted
invalid
investigation
librarydb
live-tv
lyrics
media playback
music
needs testing
nuget
performance
platform
pull-request
Mirrored from GitHub Pull Request
 question
regression
release critical
requires-web
roadmap
security
security
stale
support
syncplay
ui & ux
upstream
wontfix
No Label pull-request
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
OVERLORD
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: starred/jellyfin#13919
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?