starred/jellyfin
1
0
Fork 0
mirror of https://github.com/jellyfin/jellyfin.git synced 2026-07-16 05:43:54 +03:00
Code Issues 822 Packages Projects Releases 17 Wiki Activity

[PR #14236] [CLOSED] Change image language priority to prefer English over images with no language #13893

New Issue
Closed
opened 2026-02-07 07:20:54 +03:00 by OVERLORD · 0 comments
OVERLORD commented 2026-02-07 07:20:54 +03:00
Owner
Copy Link

📋 Pull Request Information

Original PR: https://github.com/jellyfin/jellyfin/pull/14236
Author: @rasko-dev
Created: 6/7/2025
Status: ❌ Closed

Base: master ← Head: image-language-sorting-reorder

📝 Commits (2)

  • a3d987b Changed ordering of images based on metadata language
  • fd18763 add self to CONTRIBUTORS.md

📊 Changes

2 files changed (+4 additions, -3 deletions)

View changed files

📝 CONTRIBUTORS.md (+1 -0)
📝 MediaBrowser.Model/Extensions/EnumerableExtensions.cs (+3 -3)

📄 Description

Changes
Changes the ordering of remote images to prioritize English over images with no language. This was the intended behaviour prior to #8946, which changed this in order to prevent English from being equally ranked with No language when English was the requested language. However to me it looks like the change of ordering priority was due to an oversight, as the fix could easily have kept the intended priority order.

Image ordering is now:

  1. Requested language
  2. English
  3. No language
  4. Any language

Which means that when English is the requested language, it is still prioritized higher than No language.

🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/jellyfin/jellyfin/pull/14236 **Author:** [@rasko-dev](https://github.com/rasko-dev) **Created:** 6/7/2025 **Status:** ❌ Closed **Base:** `master` ← **Head:** `image-language-sorting-reorder` --- ### 📝 Commits (2) - [`a3d987b`](https://github.com/jellyfin/jellyfin/commit/a3d987b43242d1ac6f7a836a3c797d1bb23948bc) Changed ordering of images based on metadata language - [`fd18763`](https://github.com/jellyfin/jellyfin/commit/fd187637b035b45b8dfd1c1a0a467239e2504870) add self to CONTRIBUTORS.md ### 📊 Changes **2 files changed** (+4 additions, -3 deletions) <details> <summary>View changed files</summary> 📝 `CONTRIBUTORS.md` (+1 -0) 📝 `MediaBrowser.Model/Extensions/EnumerableExtensions.cs` (+3 -3) </details> ### 📄 Description **Changes** Changes the ordering of remote images to prioritize English over images with no language. This was the intended behaviour prior to #8946, which changed this in order to prevent English from being equally ranked with No language when English was the requested language. However to me it looks like the change of ordering priority was due to an oversight, as the fix could easily have kept the intended priority order. Image ordering is now: 1. Requested language 2. English 3. No language 4. Any language Which means that when English is the requested language, it is still prioritized higher than No language. --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
OVERLORD added the pull-request label 2026-02-07 07:20:54 +03:00
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
EFjellyfin.db
area:database
awaiting-feedback
backend
blocked
breaking change: web api
bug
build
ci
confirmed
discussion needed
dotnet future
downstream
duplicate
enhancement
feature
future
github-actions
good first issue
hdr
help wanted
invalid
investigation
librarydb
live-tv
lyrics
media playback
music
needs testing
nuget
performance
platform
pull-request
Mirrored from GitHub Pull Request
 question
regression
release critical
requires-web
roadmap
security
security
stale
support
syncplay
ui & ux
upstream
wontfix
No Label pull-request
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
OVERLORD
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: starred/jellyfin#13893
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?