[PR #14100] [MERGED] Terminate at null char for audio tags #13838

Closed
opened 2026-02-07 07:19:59 +03:00 by OVERLORD · 0 comments
Owner

📋 Pull Request Information

Original PR: https://github.com/jellyfin/jellyfin/pull/14100
Author: @gnattu
Created: 5/13/2025
Status: Merged
Merged: 5/19/2025
Merged by: @crobibero

Base: masterHead: terminate-tag-at-null


📝 Commits (2)

  • 6f0e331 Terminate at null char for audio tags
  • 2541cf3 Use LeftPart extension

📊 Changes

2 files changed (+71 additions, -24 deletions)

View changed files

📝 MediaBrowser.Providers/MediaInfo/AudioFileProber.cs (+58 -24)
📝 src/Jellyfin.Extensions/StringExtensions.cs (+13 -0)

📄 Description

Some users may use a misbehaved tag editor that writes a null char to the tag when not allowed by the tagging system. Terminates all string value from the tag at null char and ignore everything after.

Having a null char in the metadata fields not only affects value display, it will actually crash some job like nfo saving where the writer cannot handle null char gracefully.

Changes

Issues

Fixes #13674


🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/jellyfin/jellyfin/pull/14100 **Author:** [@gnattu](https://github.com/gnattu) **Created:** 5/13/2025 **Status:** ✅ Merged **Merged:** 5/19/2025 **Merged by:** [@crobibero](https://github.com/crobibero) **Base:** `master` ← **Head:** `terminate-tag-at-null` --- ### 📝 Commits (2) - [`6f0e331`](https://github.com/jellyfin/jellyfin/commit/6f0e3318e56a84f88f2e5a1250279017295cf43b) Terminate at null char for audio tags - [`2541cf3`](https://github.com/jellyfin/jellyfin/commit/2541cf30afd63ceed6a59682ca185e9dda19cf9d) Use LeftPart extension ### 📊 Changes **2 files changed** (+71 additions, -24 deletions) <details> <summary>View changed files</summary> 📝 `MediaBrowser.Providers/MediaInfo/AudioFileProber.cs` (+58 -24) 📝 `src/Jellyfin.Extensions/StringExtensions.cs` (+13 -0) </details> ### 📄 Description Some users may use a misbehaved tag editor that writes a null char to the tag when not allowed by the tagging system. Terminates all string value from the tag at null char and ignore everything after. Having a null char in the metadata fields not only affects value display, it will actually crash some job like nfo saving where the writer cannot handle null char gracefully. <!-- Ensure your title is short, descriptive, and in the imperative mood (Fix X, Change Y, instead of Fixed X, Changed Y). For a good inspiration of what to write in commit messages and PRs please review https://chris.beams.io/posts/git-commit/ and our documentation. --> **Changes** <!-- Describe your changes here in 1-5 sentences. --> **Issues** <!-- Tag any issues that this PR solves here. ex. Fixes # --> Fixes #13674 --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
OVERLORD added the pull-request label 2026-02-07 07:19:59 +03:00
Sign in to join this conversation.
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: starred/jellyfin#13838