[PR #14072] [MERGED] Cleanup external item data cleanup #13829

New Issue

OVERLORD · 2026-02-07T07:19:51+03:00

OVERLORD commented

2026-02-07 07:19:51 +03:00

📋 Pull Request Information

Original PR: https://github.com/jellyfin/jellyfin/pull/14072
Author: @Shadowghost
Created: 5/6/2025
Status: ✅ Merged
Merged: 5/9/2025
Merged by: @crobibero

Base: master ← Head: cleanup-item-cleanup

📝 Commits (5)

2ff0804 Cleanup external item data cleanup
098c2ff Fixes
da03816 Rename
94d80a8 Fix circular dependency
014b28f Fix dependency circle

📊 Changes

47 files changed (+295 additions, -374 deletions)

View changed files

📝 Emby.Server.Implementations/ApplicationHost.cs (+15 -12)
➕ Emby.Server.Implementations/Library/ExternalDataManager.cs (+58 -0)
📝 Emby.Server.Implementations/Library/LibraryManager.cs (+15 -46)
📝 Emby.Server.Implementations/ScheduledTasks/Tasks/MediaSegmentExtractionTask.cs (+2 -1)
📝 Emby.Server.Implementations/Sorting/DateLastMediaAddedComparer.cs (+3 -3)
📝 Emby.Server.Implementations/Sorting/DatePlayedComparer.cs (+4 -4)
📝 Emby.Server.Implementations/Sorting/IsFavoriteOrLikeComparer.cs (+3 -3)
📝 Emby.Server.Implementations/Sorting/IsPlayedComparer.cs (+3 -3)
📝 Emby.Server.Implementations/Sorting/IsUnplayedComparer.cs (+3 -3)
📝 Emby.Server.Implementations/Sorting/PlayCountComparer.cs (+4 -4)
📝 Jellyfin.Api/Controllers/MediaSegmentsController.cs (+2 -1)
📝 Jellyfin.Server.Implementations/MediaSegments/MediaSegmentManager.cs (+8 -22)
📝 Jellyfin.Server.Implementations/Trickplay/TrickplayManager.cs (+13 -12)
📝 MediaBrowser.Controller/Entities/BaseItem.cs (+1 -1)
📝 MediaBrowser.Controller/Entities/TV/Episode.cs (+38 -1)
➕ MediaBrowser.Controller/IO/IExternalDataManager.cs (+19 -0)
📝 MediaBrowser.Controller/MediaSegments/IMediaSegmentManager.cs (+8 -13)
📝 MediaBrowser.Controller/Sorting/IUserBaseItemComparer.cs (+1 -1)
📝 MediaBrowser.Controller/Trickplay/ITrickplayManager.cs (+10 -2)
📝 MediaBrowser.Providers/Books/AudioBookMetadataService.cs (+3 -8)

...and 27 more files

📄 Description

Changes

Move the cleanup to a method to its own service
Cleanup dependencies (reduce circular dependencies)
Cleanup TrickplayInfo

_{🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.}

## 📋 Pull Request Information **Original PR:** https://github.com/jellyfin/jellyfin/pull/14072 **Author:** [@Shadowghost](https://github.com/Shadowghost) **Created:** 5/6/2025 **Status:** ✅ Merged **Merged:** 5/9/2025 **Merged by:** [@crobibero](https://github.com/crobibero) **Base:** `master` ← **Head:** `cleanup-item-cleanup` --- ### 📝 Commits (5) - [`2ff0804`](https://github.com/jellyfin/jellyfin/commit/2ff08040455356c4d221f48ee22b34af49e4caca) Cleanup external item data cleanup - [`098c2ff`](https://github.com/jellyfin/jellyfin/commit/098c2ff06900d087e0a1d71171a8addfd51113cf) Fixes - [`da03816`](https://github.com/jellyfin/jellyfin/commit/da038160717825baf6db7676d11ce2ef15589952) Rename - [`94d80a8`](https://github.com/jellyfin/jellyfin/commit/94d80a8685fc33315a631c6111b1037a10a5f2ae) Fix circular dependency - [`014b28f`](https://github.com/jellyfin/jellyfin/commit/014b28f821694efff2bb6007da6fe59be74638fe) Fix dependency circle ### 📊 Changes **47 files changed** (+295 additions, -374 deletions) <details> <summary>View changed files</summary> 📝 `Emby.Server.Implementations/ApplicationHost.cs` (+15 -12) ➕ `Emby.Server.Implementations/Library/ExternalDataManager.cs` (+58 -0) 📝 `Emby.Server.Implementations/Library/LibraryManager.cs` (+15 -46) 📝 `Emby.Server.Implementations/ScheduledTasks/Tasks/MediaSegmentExtractionTask.cs` (+2 -1) 📝 `Emby.Server.Implementations/Sorting/DateLastMediaAddedComparer.cs` (+3 -3) 📝 `Emby.Server.Implementations/Sorting/DatePlayedComparer.cs` (+4 -4) 📝 `Emby.Server.Implementations/Sorting/IsFavoriteOrLikeComparer.cs` (+3 -3) 📝 `Emby.Server.Implementations/Sorting/IsPlayedComparer.cs` (+3 -3) 📝 `Emby.Server.Implementations/Sorting/IsUnplayedComparer.cs` (+3 -3) 📝 `Emby.Server.Implementations/Sorting/PlayCountComparer.cs` (+4 -4) 📝 `Jellyfin.Api/Controllers/MediaSegmentsController.cs` (+2 -1) 📝 `Jellyfin.Server.Implementations/MediaSegments/MediaSegmentManager.cs` (+8 -22) 📝 `Jellyfin.Server.Implementations/Trickplay/TrickplayManager.cs` (+13 -12) 📝 `MediaBrowser.Controller/Entities/BaseItem.cs` (+1 -1) 📝 `MediaBrowser.Controller/Entities/TV/Episode.cs` (+38 -1) ➕ `MediaBrowser.Controller/IO/IExternalDataManager.cs` (+19 -0) 📝 `MediaBrowser.Controller/MediaSegments/IMediaSegmentManager.cs` (+8 -13) 📝 `MediaBrowser.Controller/Sorting/IUserBaseItemComparer.cs` (+1 -1) 📝 `MediaBrowser.Controller/Trickplay/ITrickplayManager.cs` (+10 -2) 📝 `MediaBrowser.Providers/Books/AudioBookMetadataService.cs` (+3 -8) _...and 27 more files_ </details> ### 📄 Description **Changes** * Move the cleanup to a method to its own service * Cleanup dependencies (reduce circular dependencies) * Cleanup `TrickplayInfo` --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>

OVERLORD added the pull-request label 2026-02-07 07:19:51 +03:00

OVERLORD closed this issue

2026-02-07 07:19:53 +03:00

Sign in to join this conversation.

Branches Tags

master

renovate/major-skiasharp-monorepo

renovate/sharpcompress-0.x

renovate/svg.skia-5.x

renovate/ghcr.io-devcontainers-features-docker-in-docker-4.x

release-10.11.z

standards-fix

release-10.9.z

openapi-cache

release-10.10.z

explicit-load

explicit-load-v2

feature/entity-framework

only-count-folder-item

fix/ci-workflow-refactor

release-10.8.z

release-10.7.z

EraYaN-add-management-interface

release-10.6.z

release-10.5.z

release-10.4.z

release-10.3.z

release-10.2.z

release-10.1.0

1 Participants

Notifications

Due Date

No due date set.

Dependencies

No dependencies set.

Reference: starred/jellyfin#13829