starred/jellyfin
1
0
Fork 0
mirror of https://github.com/jellyfin/jellyfin.git synced 2026-07-16 05:43:54 +03:00
Code Issues 822 Packages Projects Releases 17 Wiki Activity

[PR #14053] [CLOSED] Addressing minor code optimisations #13812

New Issue
Closed
opened 2026-02-07 07:19:37 +03:00 by OVERLORD · 0 comments
OVERLORD commented 2026-02-07 07:19:37 +03:00
Owner
Copy Link

📋 Pull Request Information

Original PR: https://github.com/jellyfin/jellyfin/pull/14053
Author: @JellyCoding1
Created: 5/3/2025
Status: ❌ Closed

Base: master ← Head: minor-changes

📝 Commits (1)

  • 4514e67 Addressing minor code optimisations

📊 Changes

16 files changed (+134 additions, -161 deletions)

View changed files

📝 Emby.Server.Implementations/Collections/CollectionImageProvider.cs (+5 -7)
📝 Emby.Server.Implementations/Collections/CollectionManager.cs (+5 -34)
📝 Emby.Server.Implementations/EntryPoints/LibraryChangedNotifier.cs (+23 -24)
📝 Emby.Server.Implementations/Images/ArtistImageProvider.cs (+1 -1)
📝 Emby.Server.Implementations/Images/BaseDynamicImageProvider.cs (+2 -2)
📝 Emby.Server.Implementations/Images/BaseFolderImageProvider.cs (+1 -1)
📝 Emby.Server.Implementations/Images/CollectionFolderImageProvider.cs (+14 -36)
📝 Emby.Server.Implementations/Images/DynamicImageProvider.cs (+5 -7)
📝 Emby.Server.Implementations/Images/GenreImageProvider.cs (+5 -5)
📝 Emby.Server.Implementations/Images/MusicAlbumImageProvider.cs (+1 -1)
📝 Emby.Server.Implementations/Images/MusicGenreImageProvider.cs (+7 -7)
📝 Emby.Server.Implementations/Images/PlaylistImageProvider.cs (+3 -7)
📝 Emby.Server.Implementations/Playlists/PlaylistManager.cs (+2 -3)
📝 MediaBrowser.Controller/Entities/Folder.cs (+3 -5)
📝 src/Jellyfin.Extensions/DictionaryExtensions.cs (+17 -21)
➕ tests/Jellyfin.Extensions.Tests/DictionaryExtensionTests.cs (+40 -0)

📄 Description

Changes

  • Started with a cleanup of the DictionaryExtension method 'GetFirstNotNullNorWhiteSpaceValue' + included tests
  • Continued with small improvements and minor changes across some files to better understand how the components tie together.

🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/jellyfin/jellyfin/pull/14053 **Author:** [@JellyCoding1](https://github.com/JellyCoding1) **Created:** 5/3/2025 **Status:** ❌ Closed **Base:** `master` ← **Head:** `minor-changes` --- ### 📝 Commits (1) - [`4514e67`](https://github.com/jellyfin/jellyfin/commit/4514e674be8564633a7e574e1cbc919de7e00ab0) Addressing minor code optimisations ### 📊 Changes **16 files changed** (+134 additions, -161 deletions) <details> <summary>View changed files</summary> 📝 `Emby.Server.Implementations/Collections/CollectionImageProvider.cs` (+5 -7) 📝 `Emby.Server.Implementations/Collections/CollectionManager.cs` (+5 -34) 📝 `Emby.Server.Implementations/EntryPoints/LibraryChangedNotifier.cs` (+23 -24) 📝 `Emby.Server.Implementations/Images/ArtistImageProvider.cs` (+1 -1) 📝 `Emby.Server.Implementations/Images/BaseDynamicImageProvider.cs` (+2 -2) 📝 `Emby.Server.Implementations/Images/BaseFolderImageProvider.cs` (+1 -1) 📝 `Emby.Server.Implementations/Images/CollectionFolderImageProvider.cs` (+14 -36) 📝 `Emby.Server.Implementations/Images/DynamicImageProvider.cs` (+5 -7) 📝 `Emby.Server.Implementations/Images/GenreImageProvider.cs` (+5 -5) 📝 `Emby.Server.Implementations/Images/MusicAlbumImageProvider.cs` (+1 -1) 📝 `Emby.Server.Implementations/Images/MusicGenreImageProvider.cs` (+7 -7) 📝 `Emby.Server.Implementations/Images/PlaylistImageProvider.cs` (+3 -7) 📝 `Emby.Server.Implementations/Playlists/PlaylistManager.cs` (+2 -3) 📝 `MediaBrowser.Controller/Entities/Folder.cs` (+3 -5) 📝 `src/Jellyfin.Extensions/DictionaryExtensions.cs` (+17 -21) ➕ `tests/Jellyfin.Extensions.Tests/DictionaryExtensionTests.cs` (+40 -0) </details> ### 📄 Description **Changes** - Started with a cleanup of the DictionaryExtension method 'GetFirstNotNullNorWhiteSpaceValue' + included tests - Continued with small improvements and minor changes across some files to better understand how the components tie together. --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
OVERLORD added the pull-request label 2026-02-07 07:19:37 +03:00
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
EFjellyfin.db
area:database
awaiting-feedback
backend
blocked
breaking change: web api
bug
build
ci
confirmed
discussion needed
dotnet future
downstream
duplicate
enhancement
feature
future
github-actions
good first issue
hdr
help wanted
invalid
investigation
librarydb
live-tv
lyrics
media playback
music
needs testing
nuget
performance
platform
pull-request
Mirrored from GitHub Pull Request
 question
regression
release critical
requires-web
roadmap
security
security
stale
support
syncplay
ui & ux
upstream
wontfix
No Label pull-request
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
OVERLORD
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: starred/jellyfin#13812
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?