[PR #13847] [MERGED] Rework chapter management #13739

New Issue

OVERLORD · 2026-02-07T07:18:20+03:00

OVERLORD commented

2026-02-07 07:18:20 +03:00

📋 Pull Request Information

Original PR: https://github.com/jellyfin/jellyfin/pull/13847
Author: @Shadowghost
Created: 4/6/2025
Status: ✅ Merged
Merged: 4/26/2025
Merged by: @Bond-009

Base: master ← Head: rework-chapter-management

📝 Commits (6)

c3813fe Rework chapter management
afc2c43 Extract GetChapterImagePath
8737b32 Apply review suggestions
cca585c Update MediaBrowser.Controller/Chapters/IChapterManager.cs
16a25c9 Apply review suggestions
6bd4c39 Address review comments

📊 Changes

15 files changed (+447 additions, -395 deletions)

View changed files

📝 Emby.Server.Implementations/ApplicationHost.cs (+3 -2)
➕ Emby.Server.Implementations/Chapters/ChapterManager.cs (+313 -0)
📝 Emby.Server.Implementations/Dto/DtoService.cs (+4 -5)
📝 Emby.Server.Implementations/Library/PathManager.cs (+17 -3)
➖ Emby.Server.Implementations/MediaEncoder/EncodingManager.cs (+0 -272)
📝 Emby.Server.Implementations/ScheduledTasks/Tasks/ChapterImagesTask.cs (+9 -19)
📝 Jellyfin.Server.Implementations/Item/ChapterRepository.cs (+12 -18)
➕ MediaBrowser.Controller/Chapters/IChapterManager.cs (+55 -0)
📝 MediaBrowser.Controller/Entities/BaseItem.cs (+3 -4)
📝 MediaBrowser.Controller/IO/IPathManager.cs (+15 -1)
➖ MediaBrowser.Controller/MediaEncoding/IEncodingManager.cs (+0 -28)
📝 MediaBrowser.Controller/Persistence/IChapterRepository.cs (+8 -18)
📝 MediaBrowser.Providers/MediaInfo/AudioFileProber.cs (+0 -4)
📝 MediaBrowser.Providers/MediaInfo/FFProbeVideoInfo.cs (+5 -11)
📝 MediaBrowser.Providers/MediaInfo/ProbeProvider.cs (+3 -10)

📄 Description

Reorganzed IEncodingManager to what iot actually is: IChapterManager.

Changes

Reorganize Service and repository for chapter access
Modify existing services to use the new manager instead of the repository directly
Add DeleteChapterImages Method to service
Move chapter path caclculation to PathManager

_{🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.}

## 📋 Pull Request Information **Original PR:** https://github.com/jellyfin/jellyfin/pull/13847 **Author:** [@Shadowghost](https://github.com/Shadowghost) **Created:** 4/6/2025 **Status:** ✅ Merged **Merged:** 4/26/2025 **Merged by:** [@Bond-009](https://github.com/Bond-009) **Base:** `master` ← **Head:** `rework-chapter-management` --- ### 📝 Commits (6) - [`c3813fe`](https://github.com/jellyfin/jellyfin/commit/c3813fe5a1a2ae7d4b36e3f4e17c7ec47d343a9a) Rework chapter management - [`afc2c43`](https://github.com/jellyfin/jellyfin/commit/afc2c43f60006571a00fd180413423ed169d056c) Extract GetChapterImagePath - [`8737b32`](https://github.com/jellyfin/jellyfin/commit/8737b32ddbac6fc3e1c197ff4d289621717f2fd9) Apply review suggestions - [`cca585c`](https://github.com/jellyfin/jellyfin/commit/cca585cdfaf5f6402e3fda27eaddf27569e6f583) Update MediaBrowser.Controller/Chapters/IChapterManager.cs - [`16a25c9`](https://github.com/jellyfin/jellyfin/commit/16a25c926630fa4d1b4d9e12241343d9f8fe4319) Apply review suggestions - [`6bd4c39`](https://github.com/jellyfin/jellyfin/commit/6bd4c39b8a604e00fea4d376758a4506a7f7d43a) Address review comments ### 📊 Changes **15 files changed** (+447 additions, -395 deletions) <details> <summary>View changed files</summary> 📝 `Emby.Server.Implementations/ApplicationHost.cs` (+3 -2) ➕ `Emby.Server.Implementations/Chapters/ChapterManager.cs` (+313 -0) 📝 `Emby.Server.Implementations/Dto/DtoService.cs` (+4 -5) 📝 `Emby.Server.Implementations/Library/PathManager.cs` (+17 -3) ➖ `Emby.Server.Implementations/MediaEncoder/EncodingManager.cs` (+0 -272) 📝 `Emby.Server.Implementations/ScheduledTasks/Tasks/ChapterImagesTask.cs` (+9 -19) 📝 `Jellyfin.Server.Implementations/Item/ChapterRepository.cs` (+12 -18) ➕ `MediaBrowser.Controller/Chapters/IChapterManager.cs` (+55 -0) 📝 `MediaBrowser.Controller/Entities/BaseItem.cs` (+3 -4) 📝 `MediaBrowser.Controller/IO/IPathManager.cs` (+15 -1) ➖ `MediaBrowser.Controller/MediaEncoding/IEncodingManager.cs` (+0 -28) 📝 `MediaBrowser.Controller/Persistence/IChapterRepository.cs` (+8 -18) 📝 `MediaBrowser.Providers/MediaInfo/AudioFileProber.cs` (+0 -4) 📝 `MediaBrowser.Providers/MediaInfo/FFProbeVideoInfo.cs` (+5 -11) 📝 `MediaBrowser.Providers/MediaInfo/ProbeProvider.cs` (+3 -10) </details> ### 📄 Description Reorganzed `IEncodingManager` to what iot actually is: `IChapterManager`. **Changes** * Reorganize Service and repository for chapter access * Modify existing services to use the new manager instead of the repository directly * Add `DeleteChapterImages` Method to service * Move chapter path caclculation to `PathManager` --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>

OVERLORD added the pull-request label 2026-02-07 07:18:20 +03:00

OVERLORD closed this issue

2026-02-07 07:18:22 +03:00

Sign in to join this conversation.

Branches Tags

master

renovate/major-skiasharp-monorepo

renovate/sharpcompress-0.x

renovate/svg.skia-5.x

renovate/ghcr.io-devcontainers-features-docker-in-docker-4.x

release-10.11.z

standards-fix

release-10.9.z

openapi-cache

release-10.10.z

explicit-load

explicit-load-v2

feature/entity-framework

only-count-folder-item

fix/ci-workflow-refactor

release-10.8.z

release-10.7.z

EraYaN-add-management-interface

release-10.6.z

release-10.5.z

release-10.4.z

release-10.3.z

release-10.2.z

release-10.1.0

1 Participants

Notifications

Due Date

No due date set.

Dependencies

No dependencies set.

Reference: starred/jellyfin#13739