starred/jellyfin
1
0
Fork 0
mirror of https://github.com/jellyfin/jellyfin.git synced 2026-07-16 05:43:54 +03:00
Code Issues 822 Packages Projects Releases 17 Wiki Activity

[PR #13795] [CLOSED] Fix for Session websocket not working on API Keys #13714

New Issue
Closed
opened 2026-02-07 07:17:53 +03:00 by OVERLORD · 0 comments
OVERLORD commented 2026-02-07 07:17:53 +03:00
Owner
Copy Link

📋 Pull Request Information

Original PR: https://github.com/jellyfin/jellyfin/pull/13795
Author: @CyferShepard
Created: 3/29/2025
Status: ❌ Closed

Base: master ← Head: api-key-websocket-fix

📝 Commits (10+)

  • 016a7e5 Bump version to 10.10.0
  • c6629ae Fix TMDB import failing when no IMDB ID is set for a movie (#12891)
  • 34f3ed0 Fixed Stackoverflow on MediaSourceCount
  • ba28e30 Changed stack type
  • 312ff4f Fixed disabled providers not beeing returned
  • c08d1d5 Added parameter to enable or disable library filter
  • aa4dd04 Added fast fail for no provider selected segment query
  • 0130580 Fixed interface definition
  • 54a6a33 renamed param
  • fe9c6fb Fixed enumerable

📊 Changes

85 files changed (+1050 additions, -522 deletions)

View changed files

📝 .config/dotnet-tools.json (+1 -1)
📝 CONTRIBUTORS.md (+2 -0)
📝 Directory.Packages.props (+19 -19)
📝 Emby.Naming/Emby.Naming.csproj (+1 -1)
📝 Emby.Server.Implementations/ConfigurationOptions.cs (+0 -1)
📝 Emby.Server.Implementations/IO/ManagedFileSystem.cs (+10 -0)
📝 Emby.Server.Implementations/Images/BaseDynamicImageProvider.cs (+0 -1)
📝 Emby.Server.Implementations/Library/LibraryManager.cs (+1 -9)
📝 Emby.Server.Implementations/Library/Resolvers/PlaylistResolver.cs (+1 -1)
📝 Emby.Server.Implementations/Localization/LocalizationManager.cs (+4 -2)
📝 Emby.Server.Implementations/Localization/Ratings/br.csv (+7 -1)
📝 Emby.Server.Implementations/Localization/Ratings/ca.csv (+0 -2)
📝 Emby.Server.Implementations/Localization/Ratings/es.csv (+1 -1)
📝 Emby.Server.Implementations/Localization/Ratings/gb.csv (+2 -1)
📝 Emby.Server.Implementations/Localization/Ratings/ie.csv (+1 -0)
📝 Emby.Server.Implementations/Localization/Ratings/no.csv (+1 -0)
📝 Emby.Server.Implementations/Localization/Ratings/nz.csv (+1 -0)
📝 Emby.Server.Implementations/Localization/Ratings/us.csv (+18 -16)
📝 Emby.Server.Implementations/Playlists/PlaylistManager.cs (+25 -15)
📝 Emby.Server.Implementations/ScheduledTasks/Tasks/AudioNormalizationTask.cs (+20 -6)

...and 65 more files

📄 Description

Fix for Session websocket not working on API Keys by creating a dummy device for the API

Changes
Fix for Object reference not set to an instance of an object error when attempting to start sending messages over a session info web socket for API Keys
Creates a Dummy Device to be used as this is required to create a session

Issues

#13479

🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/jellyfin/jellyfin/pull/13795 **Author:** [@CyferShepard](https://github.com/CyferShepard) **Created:** 3/29/2025 **Status:** ❌ Closed **Base:** `master` ← **Head:** `api-key-websocket-fix` --- ### 📝 Commits (10+) - [`016a7e5`](https://github.com/jellyfin/jellyfin/commit/016a7e5542a6b2a9532341f0d8e567929d138eeb) Bump version to 10.10.0 - [`c6629ae`](https://github.com/jellyfin/jellyfin/commit/c6629aebf871af861b42f711f12ff920117f4bce) Fix TMDB import failing when no IMDB ID is set for a movie (#12891) - [`34f3ed0`](https://github.com/jellyfin/jellyfin/commit/34f3ed0a4d8d233cd4415e65f81c97f9d2e4d104) Fixed Stackoverflow on MediaSourceCount - [`ba28e30`](https://github.com/jellyfin/jellyfin/commit/ba28e3041d73819b1d4f70d127ec7ae97ec42139) Changed stack type - [`312ff4f`](https://github.com/jellyfin/jellyfin/commit/312ff4f3d875b9e5c738ee20273cd9f3bd32a58c) Fixed disabled providers not beeing returned - [`c08d1d5`](https://github.com/jellyfin/jellyfin/commit/c08d1d5b7f45b41ef200e9604fa38096c1560a85) Added parameter to enable or disable library filter - [`aa4dd04`](https://github.com/jellyfin/jellyfin/commit/aa4dd04b992bdcb7f40a82ca09bc5ebc70d23df7) Added fast fail for no provider selected segment query - [`0130580`](https://github.com/jellyfin/jellyfin/commit/013058015172d596ae67327e203ca03e20658813) Fixed interface definition - [`54a6a33`](https://github.com/jellyfin/jellyfin/commit/54a6a33c017fb50812cb8c849b50843b25fc782d) renamed param - [`fe9c6fb`](https://github.com/jellyfin/jellyfin/commit/fe9c6fb8ae7d8b5c4b6362902b6e3acbc2e6df55) Fixed enumerable ### 📊 Changes **85 files changed** (+1050 additions, -522 deletions) <details> <summary>View changed files</summary> 📝 `.config/dotnet-tools.json` (+1 -1) 📝 `CONTRIBUTORS.md` (+2 -0) 📝 `Directory.Packages.props` (+19 -19) 📝 `Emby.Naming/Emby.Naming.csproj` (+1 -1) 📝 `Emby.Server.Implementations/ConfigurationOptions.cs` (+0 -1) 📝 `Emby.Server.Implementations/IO/ManagedFileSystem.cs` (+10 -0) 📝 `Emby.Server.Implementations/Images/BaseDynamicImageProvider.cs` (+0 -1) 📝 `Emby.Server.Implementations/Library/LibraryManager.cs` (+1 -9) 📝 `Emby.Server.Implementations/Library/Resolvers/PlaylistResolver.cs` (+1 -1) 📝 `Emby.Server.Implementations/Localization/LocalizationManager.cs` (+4 -2) 📝 `Emby.Server.Implementations/Localization/Ratings/br.csv` (+7 -1) 📝 `Emby.Server.Implementations/Localization/Ratings/ca.csv` (+0 -2) 📝 `Emby.Server.Implementations/Localization/Ratings/es.csv` (+1 -1) 📝 `Emby.Server.Implementations/Localization/Ratings/gb.csv` (+2 -1) 📝 `Emby.Server.Implementations/Localization/Ratings/ie.csv` (+1 -0) 📝 `Emby.Server.Implementations/Localization/Ratings/no.csv` (+1 -0) 📝 `Emby.Server.Implementations/Localization/Ratings/nz.csv` (+1 -0) 📝 `Emby.Server.Implementations/Localization/Ratings/us.csv` (+18 -16) 📝 `Emby.Server.Implementations/Playlists/PlaylistManager.cs` (+25 -15) 📝 `Emby.Server.Implementations/ScheduledTasks/Tasks/AudioNormalizationTask.cs` (+20 -6) _...and 65 more files_ </details> ### 📄 Description Fix for Session websocket not working on API Keys by creating a dummy device for the API <!-- Ensure your title is short, descriptive, and in the imperative mood (Fix X, Change Y, instead of Fixed X, Changed Y). For a good inspiration of what to write in commit messages and PRs please review https://chris.beams.io/posts/git-commit/ and our documentation. --> **Changes** Fix for `Object reference not set to an instance of an object` error when attempting to start sending messages over a session info web socket for API Keys Creates a Dummy Device to be used as this is required to create a session **Issues** <!-- Tag any issues that this PR solves here. ex. Fixes # --> #13479 --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
OVERLORD added the pull-request label 2026-02-07 07:17:53 +03:00
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
EFjellyfin.db
area:database
awaiting-feedback
backend
blocked
breaking change: web api
bug
build
ci
confirmed
discussion needed
dotnet future
downstream
duplicate
enhancement
feature
future
github-actions
good first issue
hdr
help wanted
invalid
investigation
librarydb
live-tv
lyrics
media playback
music
needs testing
nuget
performance
platform
pull-request
Mirrored from GitHub Pull Request
 question
regression
release critical
requires-web
roadmap
security
security
stale
support
syncplay
ui & ux
upstream
wontfix
No Label pull-request
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
OVERLORD
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: starred/jellyfin#13714
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?