starred/jellyfin
1
0
Fork 0
mirror of https://github.com/jellyfin/jellyfin.git synced 2026-07-16 05:43:54 +03:00
Code Issues 822 Packages Projects Releases 17 Wiki Activity

[PR #13581] [CLOSED] chore: Apply automatic refactoring #13633

New Issue
Closed
opened 2026-02-07 07:16:29 +03:00 by OVERLORD · 0 comments
OVERLORD commented 2026-02-07 07:16:29 +03:00
Owner
Copy Link

📋 Pull Request Information

Original PR: https://github.com/jellyfin/jellyfin/pull/13581
Author: @magom001
Created: 2/18/2025
Status: ❌ Closed

Base: master ← Head: chore/apply-auto-refactoring

📝 Commits (1)

  • f498c4f chore: Apply automatic refactoring

📊 Changes

1405 files changed (+109504 additions, -111091 deletions)

View changed files

📝 Directory.Build.props (+6 -4)
📝 Emby.Naming/Audio/AlbumParser.cs (+43 -44)
📝 Emby.Naming/Audio/AudioFileParser.cs (+13 -14)
📝 Emby.Naming/AudioBook/AudioBookFileInfo.cs (+58 -59)
📝 Emby.Naming/AudioBook/AudioBookFilePathParser.cs (+39 -40)
📝 Emby.Naming/AudioBook/AudioBookFilePathParserResult.cs (+12 -13)
📝 Emby.Naming/AudioBook/AudioBookInfo.cs (+43 -44)
📝 Emby.Naming/AudioBook/AudioBookListResolver.cs (+109 -110)
📝 Emby.Naming/AudioBook/AudioBookNameParser.cs (+41 -42)
📝 Emby.Naming/AudioBook/AudioBookNameParserResult.cs (+12 -13)
📝 Emby.Naming/AudioBook/AudioBookResolver.cs (+36 -37)
📝 Emby.Naming/Common/EpisodeExpression.cs (+52 -53)
📝 Emby.Naming/Common/MediaType.cs (+16 -17)
📝 Emby.Naming/Common/NamingOptions.cs (+857 -858)
📝 Emby.Naming/Emby.Naming.csproj (+0 -3)
📝 Emby.Naming/ExternalFiles/ExternalPathParser.cs (+96 -97)
📝 Emby.Naming/ExternalFiles/ExternalPathParserResult.cs (+47 -48)
📝 Emby.Naming/TV/EpisodeInfo.cs (+74 -75)
📝 Emby.Naming/TV/EpisodePathParser.cs (+163 -164)
📝 Emby.Naming/TV/EpisodePathParserResult.cs (+50 -51)

...and 80 more files

📄 Description

Changes

Almost all changes are done by IDE automation:

  • Use collection expressions
  • Switch to using namespace ...; notation
  • Replace for with foreach

Cleaned up .csproj files: moved common properties to Directory.Build.Props.

As part of #2149 replaced List with ICollection/IReadOnlyList where no other code changes were required.

Remark: I was hoping that git got smarter and would be able to recognize whitespace changes for what they are. Not the case. I understand if this PR is rejected. This refactoring can be ignored in the git history with git-revs-ignore-blame.

Issues

#2149

🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/jellyfin/jellyfin/pull/13581 **Author:** [@magom001](https://github.com/magom001) **Created:** 2/18/2025 **Status:** ❌ Closed **Base:** `master` ← **Head:** `chore/apply-auto-refactoring` --- ### 📝 Commits (1) - [`f498c4f`](https://github.com/jellyfin/jellyfin/commit/f498c4f77c28471eaafff90669195e8c7ea4acbe) chore: Apply automatic refactoring ### 📊 Changes **1405 files changed** (+109504 additions, -111091 deletions) <details> <summary>View changed files</summary> 📝 `Directory.Build.props` (+6 -4) 📝 `Emby.Naming/Audio/AlbumParser.cs` (+43 -44) 📝 `Emby.Naming/Audio/AudioFileParser.cs` (+13 -14) 📝 `Emby.Naming/AudioBook/AudioBookFileInfo.cs` (+58 -59) 📝 `Emby.Naming/AudioBook/AudioBookFilePathParser.cs` (+39 -40) 📝 `Emby.Naming/AudioBook/AudioBookFilePathParserResult.cs` (+12 -13) 📝 `Emby.Naming/AudioBook/AudioBookInfo.cs` (+43 -44) 📝 `Emby.Naming/AudioBook/AudioBookListResolver.cs` (+109 -110) 📝 `Emby.Naming/AudioBook/AudioBookNameParser.cs` (+41 -42) 📝 `Emby.Naming/AudioBook/AudioBookNameParserResult.cs` (+12 -13) 📝 `Emby.Naming/AudioBook/AudioBookResolver.cs` (+36 -37) 📝 `Emby.Naming/Common/EpisodeExpression.cs` (+52 -53) 📝 `Emby.Naming/Common/MediaType.cs` (+16 -17) 📝 `Emby.Naming/Common/NamingOptions.cs` (+857 -858) 📝 `Emby.Naming/Emby.Naming.csproj` (+0 -3) 📝 `Emby.Naming/ExternalFiles/ExternalPathParser.cs` (+96 -97) 📝 `Emby.Naming/ExternalFiles/ExternalPathParserResult.cs` (+47 -48) 📝 `Emby.Naming/TV/EpisodeInfo.cs` (+74 -75) 📝 `Emby.Naming/TV/EpisodePathParser.cs` (+163 -164) 📝 `Emby.Naming/TV/EpisodePathParserResult.cs` (+50 -51) _...and 80 more files_ </details> ### 📄 Description <!-- Ensure your title is short, descriptive, and in the imperative mood (Fix X, Change Y, instead of Fixed X, Changed Y). For a good inspiration of what to write in commit messages and PRs please review https://chris.beams.io/posts/git-commit/ and our documentation. --> **Changes** <!-- Describe your changes here in 1-5 sentences. --> Almost all changes are done by IDE automation: - Use collection expressions - Switch to using `namespace ...;` notation - Replace `for` with `foreach` Cleaned up .csproj files: moved common properties to `Directory.Build.Props`. As part of #2149 replaced `List` with `ICollection`/`IReadOnlyList` where no other code changes were required. Remark: I was hoping that git got smarter and would be able to recognize whitespace changes for what they are. Not the case. I understand if this PR is rejected. This refactoring can be ignored in the git history with `git-revs-ignore-blame`. **Issues** <!-- Tag any issues that this PR solves here. ex. Fixes # --> #2149 --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
OVERLORD added the pull-request label 2026-02-07 07:16:29 +03:00
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
EFjellyfin.db
area:database
awaiting-feedback
backend
blocked
breaking change: web api
bug
build
ci
confirmed
discussion needed
dotnet future
downstream
duplicate
enhancement
feature
future
github-actions
good first issue
hdr
help wanted
invalid
investigation
librarydb
live-tv
lyrics
media playback
music
needs testing
nuget
performance
platform
pull-request
Mirrored from GitHub Pull Request
 question
regression
release critical
requires-web
roadmap
security
security
stale
support
syncplay
ui & ux
upstream
wontfix
No Label pull-request
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
OVERLORD
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: starred/jellyfin#13633
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?