starred/jellyfin
1
0
Fork 0
mirror of https://github.com/jellyfin/jellyfin.git synced 2026-05-04 18:09:12 +03:00
Code Issues 822 Packages Projects Releases 10 Wiki Activity

[PR #13590] [CLOSED] Reduce the number of CA2227 disable pragmas #13632

New Issue
Closed
opened 2026-02-07 07:16:28 +03:00 by OVERLORD · 0 comments
OVERLORD commented 2026-02-07 07:16:28 +03:00
Owner
Copy Link

📋 Pull Request Information

Original PR: https://github.com/jellyfin/jellyfin/pull/13590
Author: @magom001
Created: 2/20/2025
Status: ❌ Closed

Base: master ← Head: chore/2149

📝 Commits (2)

📊 Changes

19 files changed (+95 additions, -169 deletions)

View changed files

📝 Emby.Server.Implementations/Data/CleanDatabaseScheduledTask.cs (+1 -1)
📝 Jellyfin.Data/Entities/BaseItemEntity.cs (+11 -14)
📝 Jellyfin.Data/Entities/BaseItemImageInfo.cs (+0 -3)
📝 Jellyfin.Data/Entities/ItemValue.cs (+2 -4)
📝 Jellyfin.Data/Entities/People.cs (+2 -4)
📝 Jellyfin.Server.Implementations/Item/BaseItemRepository.cs (+5 -4)
📝 Jellyfin.Server.Implementations/Item/PeopleRepository.cs (+4 -3)
📝 Jellyfin.Server/Migrations/Routines/MigrateLibraryDb.cs (+2 -1)
📝 MediaBrowser.Controller/Channels/InternalChannelFeatures.cs (+7 -15)
📝 MediaBrowser.Controller/Entities/InternalItemsQuery.cs (+40 -81)
📝 MediaBrowser.Controller/Entities/PersonInfo.cs (+3 -9)
📝 MediaBrowser.Controller/Library/PlaybackProgressEventArgs.cs (+2 -7)
📝 MediaBrowser.Controller/Library/UserDataSaveEventArgs.cs (+2 -2)
📝 MediaBrowser.Controller/Providers/ItemLookupInfo.cs (+2 -8)
📝 MediaBrowser.Model/Updates/PackageInfo.cs (+2 -4)
📝 MediaBrowser.Providers/Plugins/AudioDb/AudioDbAlbumProvider.cs (+2 -2)
📝 MediaBrowser.Providers/Plugins/AudioDb/AudioDbArtistProvider.cs (+1 -2)
📝 tests/Jellyfin.Extensions.Tests/Json/Models/GenericBodyListModel.cs (+2 -3)
📝 tests/Jellyfin.Server.Implementations.Tests/Plugins/PluginManagerTests.cs (+5 -2)

📄 Description

Changes

Partially remove pragma disable declarations for CA2227 + required code changes

Issues

#2149

🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/jellyfin/jellyfin/pull/13590 **Author:** [@magom001](https://github.com/magom001) **Created:** 2/20/2025 **Status:** ❌ Closed **Base:** `master` ← **Head:** `chore/2149` --- ### 📝 Commits (2) - [`c76b421`](https://github.com/jellyfin/jellyfin/commit/c76b42171631fa43901f181328fa7b823a4dd075) Reduce the number of CA2227 disable pragmas - [`ae089ee`](https://github.com/jellyfin/jellyfin/commit/ae089eeae83fb06d3f30ca665b71965be67c7986) Fix UTs ### 📊 Changes **19 files changed** (+95 additions, -169 deletions) <details> <summary>View changed files</summary> 📝 `Emby.Server.Implementations/Data/CleanDatabaseScheduledTask.cs` (+1 -1) 📝 `Jellyfin.Data/Entities/BaseItemEntity.cs` (+11 -14) 📝 `Jellyfin.Data/Entities/BaseItemImageInfo.cs` (+0 -3) 📝 `Jellyfin.Data/Entities/ItemValue.cs` (+2 -4) 📝 `Jellyfin.Data/Entities/People.cs` (+2 -4) 📝 `Jellyfin.Server.Implementations/Item/BaseItemRepository.cs` (+5 -4) 📝 `Jellyfin.Server.Implementations/Item/PeopleRepository.cs` (+4 -3) 📝 `Jellyfin.Server/Migrations/Routines/MigrateLibraryDb.cs` (+2 -1) 📝 `MediaBrowser.Controller/Channels/InternalChannelFeatures.cs` (+7 -15) 📝 `MediaBrowser.Controller/Entities/InternalItemsQuery.cs` (+40 -81) 📝 `MediaBrowser.Controller/Entities/PersonInfo.cs` (+3 -9) 📝 `MediaBrowser.Controller/Library/PlaybackProgressEventArgs.cs` (+2 -7) 📝 `MediaBrowser.Controller/Library/UserDataSaveEventArgs.cs` (+2 -2) 📝 `MediaBrowser.Controller/Providers/ItemLookupInfo.cs` (+2 -8) 📝 `MediaBrowser.Model/Updates/PackageInfo.cs` (+2 -4) 📝 `MediaBrowser.Providers/Plugins/AudioDb/AudioDbAlbumProvider.cs` (+2 -2) 📝 `MediaBrowser.Providers/Plugins/AudioDb/AudioDbArtistProvider.cs` (+1 -2) 📝 `tests/Jellyfin.Extensions.Tests/Json/Models/GenericBodyListModel.cs` (+2 -3) 📝 `tests/Jellyfin.Server.Implementations.Tests/Plugins/PluginManagerTests.cs` (+5 -2) </details> ### 📄 Description <!-- Ensure your title is short, descriptive, and in the imperative mood (Fix X, Change Y, instead of Fixed X, Changed Y). For a good inspiration of what to write in commit messages and PRs please review https://chris.beams.io/posts/git-commit/ and our documentation. --> **Changes** <!-- Describe your changes here in 1-5 sentences. --> Partially remove pragma disable declarations for CA2227 + required code changes **Issues** <!-- Tag any issues that this PR solves here. ex. Fixes # --> #2149 --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
OVERLORD added the pull-request label 2026-02-07 07:16:28 +03:00
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
EFjellyfin.db
area:database
awaiting-feedback
backend
blocked
breaking change: web api
bug
build
ci
confirmed
discussion needed
dotnet future
downstream
duplicate
enhancement
feature
future
github-actions
good first issue
hdr
help wanted
invalid
investigation
librarydb
live-tv
lyrics
media playback
music
needs testing
nuget
performance
platform
pull-request
Mirrored from GitHub Pull Request
 question
regression
release critical
requires-web
roadmap
security
security
stale
support
syncplay
ui & ux
upstream
wontfix
No Label pull-request
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
OVERLORD
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: starred/jellyfin#13632
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?