starred/jellyfin
1
0
Fork 0
mirror of https://github.com/jellyfin/jellyfin.git synced 2026-05-04 18:09:12 +03:00
Code Issues 822 Packages Projects Releases 10 Wiki Activity

[PR #13494] [MERGED] Make StartDate/EndDate nullable #13605

New Issue
Closed
opened 2026-02-07 07:15:57 +03:00 by OVERLORD · 0 comments
OVERLORD commented 2026-02-07 07:15:57 +03:00
Owner
Copy Link

📋 Pull Request Information

Original PR: https://github.com/jellyfin/jellyfin/pull/13494
Author: @gnattu
Created: 2/4/2025
Status: ✅ Merged
Merged: 2/5/2025
Merged by: @crobibero

Base: master ← Head: mark-startenddate-nullable

📝 Commits (1)

  • 98d4004 Make StartDate/EndDate nullable

📊 Changes

5 files changed (+1657 additions, -7 deletions)

View changed files

📝 Jellyfin.Data/Entities/BaseItemEntity.cs (+2 -2)
📝 Jellyfin.Server.Implementations/Item/BaseItemRepository.cs (+2 -2)
➕ Jellyfin.Server.Implementations/Migrations/20250204092455_MakeStartEndDateNullable.Designer.cs (+1595 -0)
➕ Jellyfin.Server.Implementations/Migrations/20250204092455_MakeStartEndDateNullable.cs (+55 -0)
📝 Jellyfin.Server.Implementations/Migrations/JellyfinDbModelSnapshot.cs (+3 -3)

📄 Description

These dates are used as birth date and death date for person (ask Luke for why) and a non-nullable column would cause the null date become 1901-01-01, making all living people dead.

Changes

Issues

Fixes #13157

🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/jellyfin/jellyfin/pull/13494 **Author:** [@gnattu](https://github.com/gnattu) **Created:** 2/4/2025 **Status:** ✅ Merged **Merged:** 2/5/2025 **Merged by:** [@crobibero](https://github.com/crobibero) **Base:** `master` ← **Head:** `mark-startenddate-nullable` --- ### 📝 Commits (1) - [`98d4004`](https://github.com/jellyfin/jellyfin/commit/98d4004e945432538e9469907205e2d7da657fda) Make StartDate/EndDate nullable ### 📊 Changes **5 files changed** (+1657 additions, -7 deletions) <details> <summary>View changed files</summary> 📝 `Jellyfin.Data/Entities/BaseItemEntity.cs` (+2 -2) 📝 `Jellyfin.Server.Implementations/Item/BaseItemRepository.cs` (+2 -2) ➕ `Jellyfin.Server.Implementations/Migrations/20250204092455_MakeStartEndDateNullable.Designer.cs` (+1595 -0) ➕ `Jellyfin.Server.Implementations/Migrations/20250204092455_MakeStartEndDateNullable.cs` (+55 -0) 📝 `Jellyfin.Server.Implementations/Migrations/JellyfinDbModelSnapshot.cs` (+3 -3) </details> ### 📄 Description These dates are used as birth date and death date for person (ask Luke for why) and a non-nullable column would cause the null date become 1901-01-01, making all living people dead. <!-- Ensure your title is short, descriptive, and in the imperative mood (Fix X, Change Y, instead of Fixed X, Changed Y). For a good inspiration of what to write in commit messages and PRs please review https://chris.beams.io/posts/git-commit/ and our documentation. --> **Changes** <!-- Describe your changes here in 1-5 sentences. --> **Issues** <!-- Tag any issues that this PR solves here. ex. Fixes # --> Fixes #13157 --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
OVERLORD added the pull-request label 2026-02-07 07:15:57 +03:00
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
EFjellyfin.db
area:database
awaiting-feedback
backend
blocked
breaking change: web api
bug
build
ci
confirmed
discussion needed
dotnet future
downstream
duplicate
enhancement
feature
future
github-actions
good first issue
hdr
help wanted
invalid
investigation
librarydb
live-tv
lyrics
media playback
music
needs testing
nuget
performance
platform
pull-request
Mirrored from GitHub Pull Request
 question
regression
release critical
requires-web
roadmap
security
security
stale
support
syncplay
ui & ux
upstream
wontfix
No Label pull-request
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
OVERLORD
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: starred/jellyfin#13605
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?