mirror of
https://github.com/jellyfin/jellyfin.git
synced 2026-07-16 05:43:54 +03:00
Failed RPM build on COPR. #1358
Reference in New Issue
Block a user
Delete Branch "%!s()"
Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?
Originally created by @brianjmurrell on GitHub (Mar 9, 2020).
Describe the bug
COPR RPM build failure
System (please complete the following information):
From the build.log:
Has some new dependency on
gitbeen introduced into whateveryarn installdoes? Maybe a new/first dependency using a git repo?If so, a
BuildRequires: gitlikely needs adding to the specfile.mockcan be used (requires a Linux system/docker container to run on, which can be done with GitHub Actions -- I'm not familiar with Azure Pipelines as a CI engine) to create a CI test for PRs to prevent this sort of thing from happening in the future.mockvalidates that an RPM'sBuildRequires:is complete and that no new build dependencies have been introduced.@brianjmurrell commented on GitHub (Mar 9, 2020):
Or you can of course just use COPR to build-test each PR as an additional CI stage. COPR can report status back to GitHub.
@dkanada commented on GitHub (Mar 9, 2020):
@brianjmurrell if you want to make a quick addition to the CI we would definitely merge that. We were thinking of moving the entire build process to CI anyways, so this would get COPR much closer.
@brianjmurrell commented on GitHub (Mar 10, 2020):
Have GitHub Actions been enabled on this repo?
@dkanada commented on GitHub (Mar 10, 2020):
We use Azure at the moment.
@brianjmurrell commented on GitHub (Mar 10, 2020):
Indeed, I am aware of this. However is there any issues with enabling GitHub Actions also?
In all honesty I am just not interested in learning how to build Azure pipelines.
GitHub actions report in the Checks tab just like Azure pipelines would so it would just look like yet another Check.
@joshuaboniface commented on GitHub (Mar 16, 2020):
I'd indeed love for us to use Mock to get this building automatically - I've got no issues using GitHub Actions for this if it's fully supported.
For now I'll manually add Git to the deps for 10.5.1.
@brianjmurrell commented on GitHub (Mar 16, 2020):
Have they been enabled for this repo? Although now that it's out of beta, maybe this is something that doesn't need to specifically be done and it's just enabled for everyone who wants to use it. If I can find some time, I will see if this is the case.
@stale[bot] commented on GitHub (Jul 14, 2020):
This issue has gone 120 days without comment. To avoid abandoned issues, it will be closed in 21 days if there are no new comments.
If you're the original submitter of this issue, please comment confirming if this issue still affects you in the latest release or nightlies, or close the issue if it has been fixed. If you're another user also affected by this bug, please comment confirming so. Either action will remove the stale label.
This bot exists to prevent issues from becoming stale and forgotten. Jellyfin is always moving forward, and bugs are often fixed as side effects of other changes. We therefore ask that bug report authors remain vigilant about their issues to ensure they are closed if fixed, or re-confirmed - perhaps with fresh logs or reproduction examples - regularly. If you have any questions you can reach us on Matrix or Social Media.