starred/jellyfin
1
0
Fork 0
mirror of https://github.com/jellyfin/jellyfin.git synced 2026-07-16 05:43:54 +03:00
Code Issues 822 Packages Projects Releases 17 Wiki Activity

[PR #13360] [MERGED] improve documentation for ContainerHelper class #13549

New Issue
Closed
opened 2026-02-07 07:14:55 +03:00 by OVERLORD · 0 comments
OVERLORD commented 2026-02-07 07:14:55 +03:00
Owner
Copy Link

📋 Pull Request Information

Original PR: https://github.com/jellyfin/jellyfin/pull/13360
Author: @reuterma24
Created: 1/12/2025
Status: ✅ Merged
Merged: 1/22/2025
Merged by: @Bond-009

Base: master ← Head: doc-improvement-container-helper

📝 Commits (2)

  • fdb489a improve parameter documentation for ContainsContainer method in ContainerHelper class
  • 5a02ea4 added myself to CONTRIBUTORS.md

📊 Changes

2 files changed (+11 additions, -5 deletions)

View changed files

📝 CONTRIBUTORS.md (+1 -0)
📝 MediaBrowser.Model/Extensions/ContainerHelper.cs (+10 -5)

📄 Description

Changes
Applied the following to each ContainsContainer method documentation of the ContainerHelper class:

  • added a sentence which states that all inputContainer values will be accepted in case profileContainers has a value of null or empty.

Also added myself to the contributors list 😄

Issues

addresses https://github.com/jellyfin/jellyfin/issues/13357

🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/jellyfin/jellyfin/pull/13360 **Author:** [@reuterma24](https://github.com/reuterma24) **Created:** 1/12/2025 **Status:** ✅ Merged **Merged:** 1/22/2025 **Merged by:** [@Bond-009](https://github.com/Bond-009) **Base:** `master` ← **Head:** `doc-improvement-container-helper` --- ### 📝 Commits (2) - [`fdb489a`](https://github.com/jellyfin/jellyfin/commit/fdb489ae477bfac2ad738227e9d5ea657f4fc395) improve parameter documentation for ContainsContainer method in ContainerHelper class - [`5a02ea4`](https://github.com/jellyfin/jellyfin/commit/5a02ea4a31cbefd877baf5351fe6a4e545ed24ce) added myself to CONTRIBUTORS.md ### 📊 Changes **2 files changed** (+11 additions, -5 deletions) <details> <summary>View changed files</summary> 📝 `CONTRIBUTORS.md` (+1 -0) 📝 `MediaBrowser.Model/Extensions/ContainerHelper.cs` (+10 -5) </details> ### 📄 Description <!-- Ensure your title is short, descriptive, and in the imperative mood (Fix X, Change Y, instead of Fixed X, Changed Y). For a good inspiration of what to write in commit messages and PRs please review https://chris.beams.io/posts/git-commit/ and our documentation. --> **Changes** Applied the following to each `ContainsContainer` method documentation of the `ContainerHelper` class: - added a sentence which states that all `inputContainer` values will be accepted in case `profileContainers` has a value of null or empty. Also added myself to the contributors list 😄 **Issues** <!-- Tag any issues that this PR solves here. ex. Fixes # --> addresses https://github.com/jellyfin/jellyfin/issues/13357 --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
OVERLORD added the pull-request label 2026-02-07 07:14:55 +03:00
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
EFjellyfin.db
area:database
awaiting-feedback
backend
blocked
breaking change: web api
bug
build
ci
confirmed
discussion needed
dotnet future
downstream
duplicate
enhancement
feature
future
github-actions
good first issue
hdr
help wanted
invalid
investigation
librarydb
live-tv
lyrics
media playback
music
needs testing
nuget
performance
platform
pull-request
Mirrored from GitHub Pull Request
 question
regression
release critical
requires-web
roadmap
security
security
stale
support
syncplay
ui & ux
upstream
wontfix
No Label pull-request
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
OVERLORD
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: starred/jellyfin#13549
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?