[PR #13167] [MERGED] Fix NFO ID parsing #13489

New Issue

OVERLORD · 2026-02-07T07:13:48+03:00

OVERLORD commented

2026-02-07 07:13:48 +03:00

📋 Pull Request Information

Original PR: https://github.com/jellyfin/jellyfin/pull/13167
Author: @Shadowghost
Created: 12/6/2024
Status: ✅ Merged
Merged: 12/31/2024
Merged by: @crobibero

Base: release-10.10.z ← Head: fix-nfo-id-parsing

📝 Commits (1)

86512ca Fix NFO ID parsing

📊 Changes

2 files changed (+16 additions, -14 deletions)

View changed files

📝 MediaBrowser.XbmcMetadata/Parsers/MovieNfoParser.cs (+6 -9)
📝 MediaBrowser.XbmcMetadata/Parsers/SeriesNfoParser.cs (+10 -5)

📄 Description

For some reason we assume that the id tag of an NFO always includes the TVDB id for series and IMDB id for movies.

According to the Kodi Wiki this is false. The id tag usually includes the value of the uniqueId tag which is set as default. This can be any kind of provider ID.

Changes

Do not assume the extracted id is associated to a specific provider
Only use the extracted ID if we're somewhat sure it is for a specific provider

Issues

Id extracted from unreliable id tag overrides correct id extracted from uniqueId tag

_{🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.}

## 📋 Pull Request Information **Original PR:** https://github.com/jellyfin/jellyfin/pull/13167 **Author:** [@Shadowghost](https://github.com/Shadowghost) **Created:** 12/6/2024 **Status:** ✅ Merged **Merged:** 12/31/2024 **Merged by:** [@crobibero](https://github.com/crobibero) **Base:** `release-10.10.z` ← **Head:** `fix-nfo-id-parsing` --- ### 📝 Commits (1) - [`86512ca`](https://github.com/jellyfin/jellyfin/commit/86512cab1b9c9a2ce8b108c6a72f49fcf03f43db) Fix NFO ID parsing ### 📊 Changes **2 files changed** (+16 additions, -14 deletions) <details> <summary>View changed files</summary> 📝 `MediaBrowser.XbmcMetadata/Parsers/MovieNfoParser.cs` (+6 -9) 📝 `MediaBrowser.XbmcMetadata/Parsers/SeriesNfoParser.cs` (+10 -5) </details> ### 📄 Description For some reason we assume that the `id` tag of an NFO always includes the TVDB id for series and IMDB id for movies. According to the [Kodi Wiki](https://kodi.wiki/view/NFO_files/Movies) this is false. The `id` tag usually includes the value of the `uniqueId` tag which is set as `default`. This can be any kind of provider ID. **Changes** * Do not assume the extracted id is associated to a specific provider * Only use the extracted ID if we're somewhat sure it is for a specific provider **Issues** * Id extracted from unreliable `id` tag overrides correct id extracted from `uniqueId` tag --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>

OVERLORD added the pull-request label 2026-02-07 07:13:48 +03:00

OVERLORD closed this issue

2026-02-07 07:13:50 +03:00

OVERLORD referenced this issue

2026-02-07 07:15:52 +03:00

[PR #13489] [MERGED] Fix subnet contains check #13599

OVERLORD referenced this issue

2026-02-07 07:15:53 +03:00

[PR #13493] [MERGED] Fix subnet contains check #13601

Sign in to join this conversation.