starred/jellyfin
1
0
Fork 0
mirror of https://github.com/jellyfin/jellyfin.git synced 2026-07-16 05:43:54 +03:00
Code Issues 822 Packages Projects Releases 17 Wiki Activity

[PR #13098] [MERGED] Fix subtitle selection to respect preferred language for forced subtitles #13467

New Issue
Closed
opened 2026-02-07 07:13:24 +03:00 by OVERLORD · 0 comments
OVERLORD commented 2026-02-07 07:13:24 +03:00
Owner
Copy Link

📋 Pull Request Information

Original PR: https://github.com/jellyfin/jellyfin/pull/13098
Author: @timminator
Created: 11/24/2024
Status: ✅ Merged
Merged: 3/19/2025
Merged by: @crobibero

Base: master ← Head: master

📝 Commits (1)

  • 4d4ecf5 Respect preferred language when selecting forced subtitles

📊 Changes

1 file changed (+60 additions, -26 deletions)

View changed files

📝 Emby.Server.Implementations/Library/MediaStreamSelector.cs (+60 -26)

📄 Description

Changes:
This PR addresses an issue where forced subtitles in non-preferred languages were being selected. I adjusted the subtitle selection logic for the SubtitlePlaybackMode "Smart" and "OnlyForced" to ensure that forced subtitles are only chosen if they match the user's preferred language.

Issues:
Fixes one of two issues mentioned in #10829
Fixes #11776

🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/jellyfin/jellyfin/pull/13098 **Author:** [@timminator](https://github.com/timminator) **Created:** 11/24/2024 **Status:** ✅ Merged **Merged:** 3/19/2025 **Merged by:** [@crobibero](https://github.com/crobibero) **Base:** `master` ← **Head:** `master` --- ### 📝 Commits (1) - [`4d4ecf5`](https://github.com/jellyfin/jellyfin/commit/4d4ecf563fc43da83f811245bdf2a37de9620ddf) Respect preferred language when selecting forced subtitles ### 📊 Changes **1 file changed** (+60 additions, -26 deletions) <details> <summary>View changed files</summary> 📝 `Emby.Server.Implementations/Library/MediaStreamSelector.cs` (+60 -26) </details> ### 📄 Description Changes: This PR addresses an issue where forced subtitles in non-preferred languages were being selected. I adjusted the subtitle selection logic for the SubtitlePlaybackMode "Smart" and "OnlyForced" to ensure that forced subtitles are only chosen if they match the user's preferred language. Issues: Fixes one of two issues mentioned in #10829 Fixes #11776 --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
OVERLORD added the pull-request label 2026-02-07 07:13:24 +03:00
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
EFjellyfin.db
area:database
awaiting-feedback
backend
blocked
breaking change: web api
bug
build
ci
confirmed
discussion needed
dotnet future
downstream
duplicate
enhancement
feature
future
github-actions
good first issue
hdr
help wanted
invalid
investigation
librarydb
live-tv
lyrics
media playback
music
needs testing
nuget
performance
platform
pull-request
Mirrored from GitHub Pull Request
 question
regression
release critical
requires-web
roadmap
security
security
stale
support
syncplay
ui & ux
upstream
wontfix
No Label pull-request
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
OVERLORD
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: starred/jellyfin#13467
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?