starred/jellyfin
1
0
Fork 0
mirror of https://github.com/jellyfin/jellyfin.git synced 2026-07-16 05:43:54 +03:00
Code Issues 822 Packages Projects Releases 17 Wiki Activity

[PR #13032] [CLOSED] Respect cancellation token/HTTP request aborts correctly in SymlinkFollowingPhysicalFileResultExecutor #13449

New Issue
Closed
opened 2026-02-07 07:13:02 +03:00 by OVERLORD · 0 comments
OVERLORD commented 2026-02-07 07:13:02 +03:00
Owner
Copy Link

📋 Pull Request Information

Original PR: https://github.com/jellyfin/jellyfin/pull/13032
Author: @goknsh
Created: 11/15/2024
Status: ❌ Closed

Base: release-10.10.z ← Head: goknsh-patch-1

📝 Commits (10+)

  • adfd722 Update issue template version from 10.9.11 to 10.10.0
  • 964f2a6 Auto update issue template version on new release
  • 3384d59 Translated using Weblate (Danish)
  • 874b357 Translated using Weblate (Greek)
  • 611e3fe Translated using Weblate (Hindi)
  • 70d81e0 Translated using Weblate (Arabic)
  • fded659 Update dependency Svg.Skia to 2.0.0.2
  • 268c28f Translated using Weblate (Hebrew)
  • 9782ef6 Translated using Weblate (Dutch)
  • bad5117 Translated using Weblate (Hebrew)

📊 Changes

23 files changed (+309 additions, -115 deletions)

View changed files

📝 .github/ISSUE_TEMPLATE/issue report.yml (+1 -1)
📝 .github/workflows/ci-codeql-analysis.yml (+3 -3)
📝 Directory.Packages.props (+3 -3)
📝 Emby.Naming/Common/NamingOptions.cs (+8 -0)
📝 Emby.Server.Implementations/Localization/Core/ar.json (+4 -1)
📝 Emby.Server.Implementations/Localization/Core/bg-BG.json (+7 -3)
📝 Emby.Server.Implementations/Localization/Core/ca.json (+2 -1)
📝 Emby.Server.Implementations/Localization/Core/da.json (+25 -25)
📝 Emby.Server.Implementations/Localization/Core/el.json (+7 -1)
📝 Emby.Server.Implementations/Localization/Core/es_419.json (+5 -1)
📝 Emby.Server.Implementations/Localization/Core/fi.json (+6 -1)
📝 Emby.Server.Implementations/Localization/Core/ga.json (+133 -10)
📝 Emby.Server.Implementations/Localization/Core/he.json (+7 -7)
📝 Emby.Server.Implementations/Localization/Core/hi.json (+4 -2)
📝 Emby.Server.Implementations/Localization/Core/ko.json (+7 -1)
📝 Emby.Server.Implementations/Localization/Core/mt.json (+52 -46)
📝 Emby.Server.Implementations/Localization/Core/nl.json (+2 -2)
📝 Emby.Server.Implementations/Localization/Core/zh-HK.json (+8 -1)
📝 Jellyfin.Server.Implementations/Users/UserManager.cs (+1 -1)
📝 Jellyfin.Server/Infrastructure/SymlinkFollowingPhysicalFileResultExecutor.cs (+15 -5)

...and 3 more files

📄 Description

Changes

Respects cancellation tokens/HTTP request aborts correctly in SymlinkFollowingPhysicalFileResultExecutor to ensure that files don't continue being read after the request has been aborted/closed.

Issues

Fixes #13029, #11343
Overrides #12641

🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/jellyfin/jellyfin/pull/13032 **Author:** [@goknsh](https://github.com/goknsh) **Created:** 11/15/2024 **Status:** ❌ Closed **Base:** `release-10.10.z` ← **Head:** `goknsh-patch-1` --- ### 📝 Commits (10+) - [`adfd722`](https://github.com/jellyfin/jellyfin/commit/adfd72288ee1cc9be336a90ba8214748f3e7d4be) Update issue template version from 10.9.11 to 10.10.0 - [`964f2a6`](https://github.com/jellyfin/jellyfin/commit/964f2a6a90365c25b7ca66bbb622d4c2e70d505c) Auto update issue template version on new release - [`3384d59`](https://github.com/jellyfin/jellyfin/commit/3384d5926a2011b97ade6b1053d92703e3090304) Translated using Weblate (Danish) - [`874b357`](https://github.com/jellyfin/jellyfin/commit/874b35784bd1c2d60f8e7fb0c24cd6de7b9cf25e) Translated using Weblate (Greek) - [`611e3fe`](https://github.com/jellyfin/jellyfin/commit/611e3fe0b2b4c83394951a20983b07d9e81c4e9c) Translated using Weblate (Hindi) - [`70d81e0`](https://github.com/jellyfin/jellyfin/commit/70d81e05f7c365d2b784ced267d80809842e01da) Translated using Weblate (Arabic) - [`fded659`](https://github.com/jellyfin/jellyfin/commit/fded6591e521df3aa79460c93d740ec4c78b6780) Update dependency Svg.Skia to 2.0.0.2 - [`268c28f`](https://github.com/jellyfin/jellyfin/commit/268c28fd1568fbfd910ff5c40e819d93130f10ea) Translated using Weblate (Hebrew) - [`9782ef6`](https://github.com/jellyfin/jellyfin/commit/9782ef662d009a69f8de727331d6e2bf8cbdc08f) Translated using Weblate (Dutch) - [`bad5117`](https://github.com/jellyfin/jellyfin/commit/bad51171ae62b67bc47e1c5c13423d2936841d5d) Translated using Weblate (Hebrew) ### 📊 Changes **23 files changed** (+309 additions, -115 deletions) <details> <summary>View changed files</summary> 📝 `.github/ISSUE_TEMPLATE/issue report.yml` (+1 -1) 📝 `.github/workflows/ci-codeql-analysis.yml` (+3 -3) 📝 `Directory.Packages.props` (+3 -3) 📝 `Emby.Naming/Common/NamingOptions.cs` (+8 -0) 📝 `Emby.Server.Implementations/Localization/Core/ar.json` (+4 -1) 📝 `Emby.Server.Implementations/Localization/Core/bg-BG.json` (+7 -3) 📝 `Emby.Server.Implementations/Localization/Core/ca.json` (+2 -1) 📝 `Emby.Server.Implementations/Localization/Core/da.json` (+25 -25) 📝 `Emby.Server.Implementations/Localization/Core/el.json` (+7 -1) 📝 `Emby.Server.Implementations/Localization/Core/es_419.json` (+5 -1) 📝 `Emby.Server.Implementations/Localization/Core/fi.json` (+6 -1) 📝 `Emby.Server.Implementations/Localization/Core/ga.json` (+133 -10) 📝 `Emby.Server.Implementations/Localization/Core/he.json` (+7 -7) 📝 `Emby.Server.Implementations/Localization/Core/hi.json` (+4 -2) 📝 `Emby.Server.Implementations/Localization/Core/ko.json` (+7 -1) 📝 `Emby.Server.Implementations/Localization/Core/mt.json` (+52 -46) 📝 `Emby.Server.Implementations/Localization/Core/nl.json` (+2 -2) 📝 `Emby.Server.Implementations/Localization/Core/zh-HK.json` (+8 -1) 📝 `Jellyfin.Server.Implementations/Users/UserManager.cs` (+1 -1) 📝 `Jellyfin.Server/Infrastructure/SymlinkFollowingPhysicalFileResultExecutor.cs` (+15 -5) _...and 3 more files_ </details> ### 📄 Description <!-- Ensure your title is short, descriptive, and in the imperative mood (Fix X, Change Y, instead of Fixed X, Changed Y). For a good inspiration of what to write in commit messages and PRs please review https://chris.beams.io/posts/git-commit/ and our documentation. --> **Changes** <!-- Describe your changes here in 1-5 sentences. --> Respects cancellation tokens/HTTP request aborts correctly in `SymlinkFollowingPhysicalFileResultExecutor` to ensure that files don't continue being read after the request has been aborted/closed. **Issues** <!-- Tag any issues that this PR solves here. ex. Fixes # --> Fixes #13029, #11343 Overrides #12641 --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
OVERLORD added the pull-request label 2026-02-07 07:13:02 +03:00
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
EFjellyfin.db
area:database
awaiting-feedback
backend
blocked
breaking change: web api
bug
build
ci
confirmed
discussion needed
dotnet future
downstream
duplicate
enhancement
feature
future
github-actions
good first issue
hdr
help wanted
invalid
investigation
librarydb
live-tv
lyrics
media playback
music
needs testing
nuget
performance
platform
pull-request
Mirrored from GitHub Pull Request
 question
regression
release critical
requires-web
roadmap
security
security
stale
support
syncplay
ui & ux
upstream
wontfix
No Label pull-request
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
OVERLORD
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: starred/jellyfin#13449
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?