starred/jellyfin
1
0
Fork 0
mirror of https://github.com/jellyfin/jellyfin.git synced 2026-07-16 05:43:54 +03:00
Code Issues 822 Packages Projects Releases 17 Wiki Activity

[PR #12931] [MERGED] Set AudioCodec when building stream #13421

New Issue
Closed
opened 2026-02-07 07:12:33 +03:00 by OVERLORD · 0 comments
OVERLORD commented 2026-02-07 07:12:33 +03:00
Owner
Copy Link

📋 Pull Request Information

Original PR: https://github.com/jellyfin/jellyfin/pull/12931
Author: @gnattu
Created: 11/1/2024
Status: ✅ Merged
Merged: 11/2/2024
Merged by: @nielsvanvelzen

Base: release-10.10.z ← Head: set-audio-codec-when-transcoding

📝 Commits (2)

  • b0f44f1 Set AudioCodec when building stream
  • 096e1b2 Add comments noting that comma separated codec list is not supported in pure audio transcoding for now

📊 Changes

1 file changed (+8 additions, -0 deletions)

View changed files

📝 MediaBrowser.Model/Dlna/StreamBuilder.cs (+8 -0)

📄 Description

This was not set at least since 10.9 and the transcoding behavior is close to "undefined" and in 10.10 this will not work at all. This will make the returned transcoding url from PlayBackInfo to correctly specify the desired transcoding codec. If the client wants to use the HLS controller directly it should be responsible to provide valid container and codec in the parameters.

Changes

Issues

Fixes #12926 , still requires the client to provide a valid transcoding profile.

🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/jellyfin/jellyfin/pull/12931 **Author:** [@gnattu](https://github.com/gnattu) **Created:** 11/1/2024 **Status:** ✅ Merged **Merged:** 11/2/2024 **Merged by:** [@nielsvanvelzen](https://github.com/nielsvanvelzen) **Base:** `release-10.10.z` ← **Head:** `set-audio-codec-when-transcoding` --- ### 📝 Commits (2) - [`b0f44f1`](https://github.com/jellyfin/jellyfin/commit/b0f44f1d5ac05f70e0a690418165cf5d1d70ac62) Set AudioCodec when building stream - [`096e1b2`](https://github.com/jellyfin/jellyfin/commit/096e1b29701c957e13dd482f343afc6537cb1c9a) Add comments noting that comma separated codec list is not supported in pure audio transcoding for now ### 📊 Changes **1 file changed** (+8 additions, -0 deletions) <details> <summary>View changed files</summary> 📝 `MediaBrowser.Model/Dlna/StreamBuilder.cs` (+8 -0) </details> ### 📄 Description This was not set at least since 10.9 and the transcoding behavior is close to "undefined" and in 10.10 this will not work at all. This will make the returned transcoding url from PlayBackInfo to correctly specify the desired transcoding codec. If the client wants to use the HLS controller directly it should be responsible to provide valid container and codec in the parameters. <!-- Ensure your title is short, descriptive, and in the imperative mood (Fix X, Change Y, instead of Fixed X, Changed Y). For a good inspiration of what to write in commit messages and PRs please review https://chris.beams.io/posts/git-commit/ and our documentation. --> **Changes** <!-- Describe your changes here in 1-5 sentences. --> **Issues** <!-- Tag any issues that this PR solves here. ex. Fixes # --> Fixes #12926 , still requires the client to provide a valid transcoding profile. --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
OVERLORD added the pull-request label 2026-02-07 07:12:33 +03:00
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
EFjellyfin.db
area:database
awaiting-feedback
backend
blocked
breaking change: web api
bug
build
ci
confirmed
discussion needed
dotnet future
downstream
duplicate
enhancement
feature
future
github-actions
good first issue
hdr
help wanted
invalid
investigation
librarydb
live-tv
lyrics
media playback
music
needs testing
nuget
performance
platform
pull-request
Mirrored from GitHub Pull Request
 question
regression
release critical
requires-web
roadmap
security
security
stale
support
syncplay
ui & ux
upstream
wontfix
No Label pull-request
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
OVERLORD
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: starred/jellyfin#13421
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?