starred/jellyfin
1
0
Fork 0
mirror of https://github.com/jellyfin/jellyfin.git synced 2026-07-16 05:43:54 +03:00
Code Issues 822 Packages Projects Releases 17 Wiki Activity

[PR #12925] [MERGED] Always await instead of directly returning Task #13419

New Issue
Closed
opened 2026-02-07 07:12:32 +03:00 by OVERLORD · 0 comments
OVERLORD commented 2026-02-07 07:12:32 +03:00
Owner
Copy Link

📋 Pull Request Information

Original PR: https://github.com/jellyfin/jellyfin/pull/12925
Author: @Bond-009
Created: 10/31/2024
Status: ✅ Merged
Merged: 1/28/2025
Merged by: @Bond-009

Base: master ← Head: await

📝 Commits (1)

  • d2db700 Always await instead of directly returning Task

📊 Changes

14 files changed (+60 additions, -91 deletions)

View changed files

📝 Emby.Server.Implementations/HttpServer/WebSocketConnection.cs (+7 -7)
📝 Emby.Server.Implementations/HttpServer/WebSocketManager.cs (+2 -2)
📝 Emby.Server.Implementations/Session/SessionWebSocketListener.cs (+3 -3)
📝 Jellyfin.Api/Controllers/DynamicHlsController.cs (+3 -3)
📝 Jellyfin.Api/Formatters/CssOutputFormatter.cs (+4 -20)
📝 Jellyfin.Api/Formatters/XmlOutputFormatter.cs (+1 -14)
📝 Jellyfin.Server/Infrastructure/SymlinkFollowingPhysicalFileResultExecutor.cs (+9 -7)
📝 MediaBrowser.Controller/Entities/Audio/MusicArtist.cs (+3 -3)
📝 MediaBrowser.Controller/Entities/BaseItem.cs (+9 -11)
📝 MediaBrowser.Controller/Entities/Folder.cs (+6 -6)
📝 MediaBrowser.LocalMetadata/Savers/PlaylistXmlSaver.cs (+3 -3)
📝 MediaBrowser.Providers/Plugins/AudioDb/AudioDbAlbumProvider.cs (+5 -7)
📝 MediaBrowser.Providers/Plugins/AudioDb/AudioDbArtistProvider.cs (+3 -3)
📝 MediaBrowser.Providers/Plugins/StudioImages/StudiosImageProvider.cs (+2 -2)

📄 Description

https://github.com/davidfowl/AspNetCoreDiagnosticScenarios/blob/master/AsyncGuidance.md#prefer-asyncawait-over-directly-returning-task

The performance impact is negligible (and it's me saying that!)

🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/jellyfin/jellyfin/pull/12925 **Author:** [@Bond-009](https://github.com/Bond-009) **Created:** 10/31/2024 **Status:** ✅ Merged **Merged:** 1/28/2025 **Merged by:** [@Bond-009](https://github.com/Bond-009) **Base:** `master` ← **Head:** `await` --- ### 📝 Commits (1) - [`d2db700`](https://github.com/jellyfin/jellyfin/commit/d2db7004024c6bbdd541a381c673f1e0b0aebfcb) Always await instead of directly returning Task ### 📊 Changes **14 files changed** (+60 additions, -91 deletions) <details> <summary>View changed files</summary> 📝 `Emby.Server.Implementations/HttpServer/WebSocketConnection.cs` (+7 -7) 📝 `Emby.Server.Implementations/HttpServer/WebSocketManager.cs` (+2 -2) 📝 `Emby.Server.Implementations/Session/SessionWebSocketListener.cs` (+3 -3) 📝 `Jellyfin.Api/Controllers/DynamicHlsController.cs` (+3 -3) 📝 `Jellyfin.Api/Formatters/CssOutputFormatter.cs` (+4 -20) 📝 `Jellyfin.Api/Formatters/XmlOutputFormatter.cs` (+1 -14) 📝 `Jellyfin.Server/Infrastructure/SymlinkFollowingPhysicalFileResultExecutor.cs` (+9 -7) 📝 `MediaBrowser.Controller/Entities/Audio/MusicArtist.cs` (+3 -3) 📝 `MediaBrowser.Controller/Entities/BaseItem.cs` (+9 -11) 📝 `MediaBrowser.Controller/Entities/Folder.cs` (+6 -6) 📝 `MediaBrowser.LocalMetadata/Savers/PlaylistXmlSaver.cs` (+3 -3) 📝 `MediaBrowser.Providers/Plugins/AudioDb/AudioDbAlbumProvider.cs` (+5 -7) 📝 `MediaBrowser.Providers/Plugins/AudioDb/AudioDbArtistProvider.cs` (+3 -3) 📝 `MediaBrowser.Providers/Plugins/StudioImages/StudiosImageProvider.cs` (+2 -2) </details> ### 📄 Description https://github.com/davidfowl/AspNetCoreDiagnosticScenarios/blob/master/AsyncGuidance.md#prefer-asyncawait-over-directly-returning-task The performance impact is negligible (and it's me saying that!) --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
OVERLORD added the pull-request label 2026-02-07 07:12:32 +03:00
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
EFjellyfin.db
area:database
awaiting-feedback
backend
blocked
breaking change: web api
bug
build
ci
confirmed
discussion needed
dotnet future
downstream
duplicate
enhancement
feature
future
github-actions
good first issue
hdr
help wanted
invalid
investigation
librarydb
live-tv
lyrics
media playback
music
needs testing
nuget
performance
platform
pull-request
Mirrored from GitHub Pull Request
 question
regression
release critical
requires-web
roadmap
security
security
stale
support
syncplay
ui & ux
upstream
wontfix
No Label pull-request
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
OVERLORD
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: starred/jellyfin#13419
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?