starred/jellyfin
1
0
Fork 0
mirror of https://github.com/jellyfin/jellyfin.git synced 2026-07-16 05:43:54 +03:00
Code Issues 822 Packages Projects Releases 17 Wiki Activity

[PR #12786] [MERGED] Ensure Skia images are always disposed #13370

New Issue
Closed
opened 2026-02-07 07:11:47 +03:00 by OVERLORD · 0 comments
OVERLORD commented 2026-02-07 07:11:47 +03:00
Owner
Copy Link

📋 Pull Request Information

Original PR: https://github.com/jellyfin/jellyfin/pull/12786
Author: @JPVenson
Created: 10/7/2024
Status: ✅ Merged
Merged: 10/17/2024
Merged by: @crobibero

Base: master ← Head: skiaDispose_master

📝 Commits (9)

  • 1d1547e Added catch statement for otherwise undisposed bitmaps
  • bf29020 reverted stream writer
  • 494458a Fixed error log
  • 2e8beea Merge branch 'jellyfin:master' into skiaDispose_master
  • 4c0cd47 fixed logline
  • 1f6ad4d Added exception to skia handling log
  • d101b8e Fixed missing loglines
  • 875f1b0 Fixed inconsistent dispose pattern
  • 9be3216 Merge branch 'jellyfin:master' into skiaDispose_master

📊 Changes

2 files changed (+194 additions, -130 deletions)

View changed files

📝 src/Jellyfin.Drawing.Skia/SkiaEncoder.cs (+98 -59)
📝 src/Jellyfin.Drawing.Skia/SplashscreenBuilder.cs (+96 -71)

📄 Description

If there are transiant errors while handing skia wrapped images, skia objects are not always disposed correctly.

Fixes:
Possible memory leaks

🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/jellyfin/jellyfin/pull/12786 **Author:** [@JPVenson](https://github.com/JPVenson) **Created:** 10/7/2024 **Status:** ✅ Merged **Merged:** 10/17/2024 **Merged by:** [@crobibero](https://github.com/crobibero) **Base:** `master` ← **Head:** `skiaDispose_master` --- ### 📝 Commits (9) - [`1d1547e`](https://github.com/jellyfin/jellyfin/commit/1d1547ec338dcc12a187c7dd7cf91069c2bd5b13) Added catch statement for otherwise undisposed bitmaps - [`bf29020`](https://github.com/jellyfin/jellyfin/commit/bf29020af6e23163cb7a29012750ff2767385c9a) reverted stream writer - [`494458a`](https://github.com/jellyfin/jellyfin/commit/494458a02fe27a4c382d8188a94071cb0366fd55) Fixed error log - [`2e8beea`](https://github.com/jellyfin/jellyfin/commit/2e8beea532e58794de815350375e132304017d2e) Merge branch 'jellyfin:master' into skiaDispose_master - [`4c0cd47`](https://github.com/jellyfin/jellyfin/commit/4c0cd47be5822b0fe0a60d0b6c0081d322ce282d) fixed logline - [`1f6ad4d`](https://github.com/jellyfin/jellyfin/commit/1f6ad4dcf7a1b1c08e3b43b3fcfcbf5beb8f6392) Added exception to skia handling log - [`d101b8e`](https://github.com/jellyfin/jellyfin/commit/d101b8ed136d9e3e1ba077bc5c791a0ca4594ca4) Fixed missing loglines - [`875f1b0`](https://github.com/jellyfin/jellyfin/commit/875f1b0d143a9351cddbd2eb1fac3a7581bdc1f7) Fixed inconsistent dispose pattern - [`9be3216`](https://github.com/jellyfin/jellyfin/commit/9be3216601a3c14387a79d965c5b46fabc938e55) Merge branch 'jellyfin:master' into skiaDispose_master ### 📊 Changes **2 files changed** (+194 additions, -130 deletions) <details> <summary>View changed files</summary> 📝 `src/Jellyfin.Drawing.Skia/SkiaEncoder.cs` (+98 -59) 📝 `src/Jellyfin.Drawing.Skia/SplashscreenBuilder.cs` (+96 -71) </details> ### 📄 Description If there are transiant errors while handing skia wrapped images, skia objects are not always disposed correctly. Fixes: Possible memory leaks --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
OVERLORD added the pull-request label 2026-02-07 07:11:47 +03:00
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
EFjellyfin.db
area:database
awaiting-feedback
backend
blocked
breaking change: web api
bug
build
ci
confirmed
discussion needed
dotnet future
downstream
duplicate
enhancement
feature
future
github-actions
good first issue
hdr
help wanted
invalid
investigation
librarydb
live-tv
lyrics
media playback
music
needs testing
nuget
performance
platform
pull-request
Mirrored from GitHub Pull Request
 question
regression
release critical
requires-web
roadmap
security
security
stale
support
syncplay
ui & ux
upstream
wontfix
No Label pull-request
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
OVERLORD
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: starred/jellyfin#13370
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?