mirror of
https://github.com/jellyfin/jellyfin.git
synced 2026-07-16 05:43:54 +03:00
[PR #12737] [CLOSED] Never set RemoveOldMetadata when replacing all metadata. #13343
Reference in New Issue
Block a user
Delete Branch "%!s()"
Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?
📋 Pull Request Information
Original PR: https://github.com/jellyfin/jellyfin/pull/12737
Author: @nielsvanvelzen
Created: 9/28/2024
Status: ❌ Closed
Base:
master← Head:fix-season-unknown-for-real📝 Commits (1)
5d0b5b6Never set RemoveOldMetadata when replacing all metadata.📊 Changes
1 file changed (+1 additions, -2 deletions)
View changed files
📝
Jellyfin.Api/Controllers/ItemRefreshController.cs(+1 -2)📄 Description
When RemoveOldMetadata is set it will clear all existing metadata from items before applying the new information. This breaks virtual seasons as episodes will never have a ParentIndexNumber set unless the season is part of the episode file name (which in a lot of cases, it is not). The fallback to "season 1" is only available in EpisodeResolver which is not called during metadata refresh. When the ParentIndexId is reset to null the RemoveObsoleteSeasons method in SeriesMetadataService will remove the virtual season(s) as it thinks there are no episodes in them.
This change only affects the behavior when using a full metadata refresh, other cases of the season unknown issue have been fixed in my previous fixes (#12240 and #12356) in 10.9.z releases.
Changes
Issues
🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.