mirror of
https://github.com/jellyfin/jellyfin.git
synced 2026-07-16 05:43:54 +03:00
[PR #12721] [MERGED] Skip allowed tags check for parents of an item #13338
Reference in New Issue
Block a user
Delete Branch "%!s()"
Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?
📋 Pull Request Information
Original PR: https://github.com/jellyfin/jellyfin/pull/12721
Author: @elfalem
Created: 9/26/2024
Status: ✅ Merged
Merged: 2/9/2025
Merged by: @crobibero
Base:
release-10.10.z← Head:allowed-tags-subfolders📝 Commits (1)
7878ae6Skip allowed tags check for parents of an item📊 Changes
6 files changed (+20 additions, -18 deletions)
View changed files
📝
MediaBrowser.Controller/Channels/Channel.cs(+2 -2)📝
MediaBrowser.Controller/Entities/BaseItem.cs(+9 -7)📝
MediaBrowser.Controller/Entities/CollectionFolder.cs(+2 -2)📝
MediaBrowser.Controller/Entities/Folder.cs(+2 -2)📝
MediaBrowser.Controller/Entities/Movies/BoxSet.cs(+3 -3)📝
MediaBrowser.Controller/Playlists/Playlist.cs(+2 -2)📄 Description
The current logic is described in this comment. In short, the allowed tags check traverses the hierarchy of an item and checks all parents. This is usually desirable for blocked tags since an item shouldn't be visible if it or any of its parents are blocked. However, similar logic makes it cumbersome/impractical to use allowed tags because they would have to be applied to all parents of an item in addition to the item.
Changes
The changes skip checking allowed tags on parents of an item. The item itself is still checked. No changes are made to blocked tags or parental ratings logic.
Issues
Fixes #11869
🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.