starred/jellyfin
1
0
Fork 0
mirror of https://github.com/jellyfin/jellyfin.git synced 2026-07-16 05:43:54 +03:00
Code Issues 822 Packages Projects Releases 17 Wiki Activity

[PR #12692] [MERGED] Fix libx264/libx265 auto preset #13331

New Issue
Closed
opened 2026-02-07 07:11:06 +03:00 by OVERLORD · 0 comments
OVERLORD commented 2026-02-07 07:11:06 +03:00
Owner
Copy Link

📋 Pull Request Information

Original PR: https://github.com/jellyfin/jellyfin/pull/12692
Author: @gnattu
Created: 9/23/2024
Status: ✅ Merged
Merged: 9/23/2024
Merged by: @crobibero

Base: master ← Head: fix-sw-auto-preset

📝 Commits (1)

  • 108d5af Fix libx264/libx265 auto preset

📊 Changes

1 file changed (+7 additions, -1 deletions)

View changed files

📝 MediaBrowser.Controller/MediaEncoding/EncodingHelper.cs (+7 -1)

📄 Description

We need to normalize auto to veryfast instead of convert it so string directly. auto is not a valid preset.

In my opinion just using the enum ToString failed for all our use cases now and all code path requires extra normalization. I plan to add an extension to have our own ToString method to turn this into CLI parameters. But that would break the ABI so not for now.

Changes

  • Fix software transcoding with auto preset.

Issues

🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/jellyfin/jellyfin/pull/12692 **Author:** [@gnattu](https://github.com/gnattu) **Created:** 9/23/2024 **Status:** ✅ Merged **Merged:** 9/23/2024 **Merged by:** [@crobibero](https://github.com/crobibero) **Base:** `master` ← **Head:** `fix-sw-auto-preset` --- ### 📝 Commits (1) - [`108d5af`](https://github.com/jellyfin/jellyfin/commit/108d5af486bb0472779a41262d86b42f3fd9716a) Fix libx264/libx265 auto preset ### 📊 Changes **1 file changed** (+7 additions, -1 deletions) <details> <summary>View changed files</summary> 📝 `MediaBrowser.Controller/MediaEncoding/EncodingHelper.cs` (+7 -1) </details> ### 📄 Description We need to normalize auto to veryfast instead of convert it so string directly. `auto` is not a valid preset. In my opinion just using the enum `ToString` failed for all our use cases now and all code path requires extra normalization. I plan to add an extension to have our own `ToString` method to turn this into CLI parameters. But that would break the ABI so not for now. <!-- Ensure your title is short, descriptive, and in the imperative mood (Fix X, Change Y, instead of Fixed X, Changed Y). For a good inspiration of what to write in commit messages and PRs please review https://chris.beams.io/posts/git-commit/ and our documentation. --> **Changes** <!-- Describe your changes here in 1-5 sentences. --> - Fix software transcoding with auto preset. **Issues** <!-- Tag any issues that this PR solves here. ex. Fixes # --> --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
OVERLORD added the pull-request label 2026-02-07 07:11:06 +03:00
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
EFjellyfin.db
area:database
awaiting-feedback
backend
blocked
breaking change: web api
bug
build
ci
confirmed
discussion needed
dotnet future
downstream
duplicate
enhancement
feature
future
github-actions
good first issue
hdr
help wanted
invalid
investigation
librarydb
live-tv
lyrics
media playback
music
needs testing
nuget
performance
platform
pull-request
Mirrored from GitHub Pull Request
 question
regression
release critical
requires-web
roadmap
security
security
stale
support
syncplay
ui & ux
upstream
wontfix
No Label pull-request
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
OVERLORD
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: starred/jellyfin#13331
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?