starred/jellyfin
1
0
Fork 0
mirror of https://github.com/jellyfin/jellyfin.git synced 2026-05-04 18:09:12 +03:00
Code Issues 822 Packages Projects Releases 10 Wiki Activity

[PR #12680] [MERGED] Fix the diff between requested and actual resolution in RKMPP #13319

New Issue
Closed
opened 2026-02-07 07:10:53 +03:00 by OVERLORD · 0 comments
OVERLORD commented 2026-02-07 07:10:53 +03:00
Owner
Copy Link

📋 Pull Request Information

Original PR: https://github.com/jellyfin/jellyfin/pull/12680
Author: @nyanmisaka
Created: 9/22/2024
Status: ✅ Merged
Merged: 9/22/2024
Merged by: @crobibero

Base: master ← Head: fix-rkmpp-aspect-ratio

📝 Commits (3)

  • d8d9f19 Fix the diff between requested and actual resolution in RKMPP
  • 1392419 Fix HW decoder may be disabled by Trickplay scanning
  • 1ebe277 Fix more about 2pass downscaling

📊 Changes

1 file changed (+3 additions, -17 deletions)

View changed files

📝 MediaBrowser.Controller/MediaEncoding/EncodingHelper.cs (+3 -17)

📄 Description

Changes

  • Fix the diff between requested and actual resolution in RKMPP
  • Fix HW decoder may be disabled by Trickplay scanning
  • Fix more about 2pass downscaling

Issues

  • The force_original_aspect_ratio=decrease option is enabled by default in scale_rkrga filter.
    But Trickplay doesn't like this. Switch to using vpp_rkrga filter instead.
[ERR] [36] Jellyfin.Server.Implementations.Trickplay.TrickplayManager: Error creating trickplay images.
System.InvalidOperationException: Image width does not match provided width.
...
  • If the hardware decoder is not available, it should do nothing instead of unchecking that decoder.

🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/jellyfin/jellyfin/pull/12680 **Author:** [@nyanmisaka](https://github.com/nyanmisaka) **Created:** 9/22/2024 **Status:** ✅ Merged **Merged:** 9/22/2024 **Merged by:** [@crobibero](https://github.com/crobibero) **Base:** `master` ← **Head:** `fix-rkmpp-aspect-ratio` --- ### 📝 Commits (3) - [`d8d9f19`](https://github.com/jellyfin/jellyfin/commit/d8d9f1970a40748235b123bde06476dd02655547) Fix the diff between requested and actual resolution in RKMPP - [`1392419`](https://github.com/jellyfin/jellyfin/commit/13924193b9be69551f095e1c415d058c17d45e8a) Fix HW decoder may be disabled by Trickplay scanning - [`1ebe277`](https://github.com/jellyfin/jellyfin/commit/1ebe2778a04bcbc4330e42b801723047e03bb589) Fix more about 2pass downscaling ### 📊 Changes **1 file changed** (+3 additions, -17 deletions) <details> <summary>View changed files</summary> 📝 `MediaBrowser.Controller/MediaEncoding/EncodingHelper.cs` (+3 -17) </details> ### 📄 Description **Changes** - Fix the diff between requested and actual resolution in RKMPP - Fix HW decoder may be disabled by Trickplay scanning - Fix more about 2pass downscaling **Issues** - The `force_original_aspect_ratio=decrease` option is enabled by default in `scale_rkrga` filter. But Trickplay doesn't like this. Switch to using `vpp_rkrga` filter instead. ``` [ERR] [36] Jellyfin.Server.Implementations.Trickplay.TrickplayManager: Error creating trickplay images. System.InvalidOperationException: Image width does not match provided width. ... ``` - If the hardware decoder is not available, it should do nothing instead of unchecking that decoder. --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
OVERLORD added the pull-request label 2026-02-07 07:10:53 +03:00
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
EFjellyfin.db
area:database
awaiting-feedback
backend
blocked
breaking change: web api
bug
build
ci
confirmed
discussion needed
dotnet future
downstream
duplicate
enhancement
feature
future
github-actions
good first issue
hdr
help wanted
invalid
investigation
librarydb
live-tv
lyrics
media playback
music
needs testing
nuget
performance
platform
pull-request
Mirrored from GitHub Pull Request
 question
regression
release critical
requires-web
roadmap
security
security
stale
support
syncplay
ui & ux
upstream
wontfix
No Label pull-request
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
OVERLORD
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: starred/jellyfin#13319
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?