starred/jellyfin
1
0
Fork 0
mirror of https://github.com/jellyfin/jellyfin.git synced 2026-07-16 05:43:54 +03:00
Code Issues 822 Packages Projects Releases 17 Wiki Activity

[PR #12679] [MERGED] Fix DeviceProfile.Id should be nullable #13317

New Issue
Closed
opened 2026-02-07 07:10:52 +03:00 by OVERLORD · 0 comments
OVERLORD commented 2026-02-07 07:10:52 +03:00
Owner
Copy Link

📋 Pull Request Information

Original PR: https://github.com/jellyfin/jellyfin/pull/12679
Author: @nielsvanvelzen
Created: 9/22/2024
Status: ✅ Merged
Merged: 9/22/2024
Merged by: @crobibero

Base: master ← Head: device-profile-id-null

📝 Commits (1)

  • b5516b2 Fix DeviceProfile.Id should be nullable

📊 Changes

2 files changed (+3 additions, -3 deletions)

View changed files

📝 MediaBrowser.Model/Dlna/DeviceProfile.cs (+1 -1)
📝 MediaBrowser.Model/Dlna/StreamBuilder.cs (+2 -2)

📄 Description

Previously (10.9<=) the id of a device profile was a nullable string. This was changed to a GUID during the 10.10 development but with this change the nullability was removed. A lot of clients (Android TV included) do not set a id so this is was a breaking change. The only 2 usages of the id still accept null so I've made the id nullable to keep compatibility.

Changes

  • Fix DeviceProfile.Id should be nullable

Issues

🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/jellyfin/jellyfin/pull/12679 **Author:** [@nielsvanvelzen](https://github.com/nielsvanvelzen) **Created:** 9/22/2024 **Status:** ✅ Merged **Merged:** 9/22/2024 **Merged by:** [@crobibero](https://github.com/crobibero) **Base:** `master` ← **Head:** `device-profile-id-null` --- ### 📝 Commits (1) - [`b5516b2`](https://github.com/jellyfin/jellyfin/commit/b5516b277937cf80ee4f6375034df24890727f48) Fix DeviceProfile.Id should be nullable ### 📊 Changes **2 files changed** (+3 additions, -3 deletions) <details> <summary>View changed files</summary> 📝 `MediaBrowser.Model/Dlna/DeviceProfile.cs` (+1 -1) 📝 `MediaBrowser.Model/Dlna/StreamBuilder.cs` (+2 -2) </details> ### 📄 Description Previously (10.9<=) the id of a device profile was a nullable string. This was changed to a GUID during the 10.10 development but with this change the nullability was removed. A lot of clients (Android TV included) do not set a id so this is was a breaking change. The only 2 usages of the id still accept null so I've made the id nullable to keep compatibility. **Changes** - Fix DeviceProfile.Id should be nullable <!-- Describe your changes here in 1-5 sentences. --> **Issues** <!-- Tag any issues that this PR solves here. ex. Fixes # --> --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
OVERLORD added the pull-request label 2026-02-07 07:10:52 +03:00
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
EFjellyfin.db
area:database
awaiting-feedback
backend
blocked
breaking change: web api
bug
build
ci
confirmed
discussion needed
dotnet future
downstream
duplicate
enhancement
feature
future
github-actions
good first issue
hdr
help wanted
invalid
investigation
librarydb
live-tv
lyrics
media playback
music
needs testing
nuget
performance
platform
pull-request
Mirrored from GitHub Pull Request
 question
regression
release critical
requires-web
roadmap
security
security
stale
support
syncplay
ui & ux
upstream
wontfix
No Label pull-request
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
OVERLORD
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: starred/jellyfin#13317
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?