starred/jellyfin
1
0
Fork 0
mirror of https://github.com/jellyfin/jellyfin.git synced 2026-07-16 05:43:54 +03:00
Code Issues 822 Packages Projects Releases 17 Wiki Activity

[PR #12660] [MERGED] Fix subtitle dar comparison when number not exact #13308

New Issue
Closed
opened 2026-02-07 07:10:41 +03:00 by OVERLORD · 0 comments
OVERLORD commented 2026-02-07 07:10:41 +03:00
Owner
Copy Link

📋 Pull Request Information

Original PR: https://github.com/jellyfin/jellyfin/pull/12660
Author: @gnattu
Created: 9/17/2024
Status: ✅ Merged
Merged: 9/17/2024
Merged by: @crobibero

Base: master ← Head: fix-dar-compare

📝 Commits (1)

  • cb32f70 Fix subtitle dar comparison when number not exact

📊 Changes

1 file changed (+1 additions, -1 deletions)

View changed files

📝 MediaBrowser.Controller/MediaEncoding/EncodingHelper.cs (+1 -1)

📄 Description

Due to precision issue the dar value should be same might not be exactly equal. Lower the precision requirement to allow more subtitles not be padded.

Changes

Issues

🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/jellyfin/jellyfin/pull/12660 **Author:** [@gnattu](https://github.com/gnattu) **Created:** 9/17/2024 **Status:** ✅ Merged **Merged:** 9/17/2024 **Merged by:** [@crobibero](https://github.com/crobibero) **Base:** `master` ← **Head:** `fix-dar-compare` --- ### 📝 Commits (1) - [`cb32f70`](https://github.com/jellyfin/jellyfin/commit/cb32f70dc34e879b8a275d69cfa807ff5e257c75) Fix subtitle dar comparison when number not exact ### 📊 Changes **1 file changed** (+1 additions, -1 deletions) <details> <summary>View changed files</summary> 📝 `MediaBrowser.Controller/MediaEncoding/EncodingHelper.cs` (+1 -1) </details> ### 📄 Description Due to precision issue the dar value should be same might not be exactly equal. Lower the precision requirement to allow more subtitles not be padded. <!-- Ensure your title is short, descriptive, and in the imperative mood (Fix X, Change Y, instead of Fixed X, Changed Y). For a good inspiration of what to write in commit messages and PRs please review https://chris.beams.io/posts/git-commit/ and our documentation. --> **Changes** <!-- Describe your changes here in 1-5 sentences. --> **Issues** <!-- Tag any issues that this PR solves here. ex. Fixes # --> --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
OVERLORD added the pull-request label 2026-02-07 07:10:41 +03:00
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
EFjellyfin.db
area:database
awaiting-feedback
backend
blocked
breaking change: web api
bug
build
ci
confirmed
discussion needed
dotnet future
downstream
duplicate
enhancement
feature
future
github-actions
good first issue
hdr
help wanted
invalid
investigation
librarydb
live-tv
lyrics
media playback
music
needs testing
nuget
performance
platform
pull-request
Mirrored from GitHub Pull Request
 question
regression
release critical
requires-web
roadmap
security
security
stale
support
syncplay
ui & ux
upstream
wontfix
No Label pull-request
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
OVERLORD
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: starred/jellyfin#13308
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?