[PR #12521] [MERGED] Fix CodecProfiles and video encoder profiles #13236

Closed
opened 2026-02-07 07:09:23 +03:00 by OVERLORD · 0 comments
Owner

📋 Pull Request Information

Original PR: https://github.com/jellyfin/jellyfin/pull/12521
Author: @nyanmisaka
Created: 8/26/2024
Status: Merged
Merged: 8/28/2024
Merged by: @crobibero

Base: release-10.9.zHead: fix-profiles


📝 Commits (2)

  • 9f1df1e Fix CodecProfiles not taking effect during transcoding
  • 7bd971f Only apply known video encoder profiles

📊 Changes

2 files changed (+22 additions, -3 deletions)

View changed files

📝 MediaBrowser.Controller/MediaEncoding/EncodingHelper.cs (+20 -1)
📝 MediaBrowser.Model/Dlna/StreamBuilder.cs (+2 -2)

📄 Description

Changes

  • Fix CodecProfiles not taking effect during transcoding

    Fixed the issue where only CodecProfiles matching the source video codec were applied during transcoding.
    The target codec of the transcoding is not necessarily the same as the source codec.

    Partically reverts #9723,
    because this line already fixed the issue described in #9411


  • Only apply known video encoder profiles

    To avoid passing invalid profiles to ffmpeg.

Issues


🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/jellyfin/jellyfin/pull/12521 **Author:** [@nyanmisaka](https://github.com/nyanmisaka) **Created:** 8/26/2024 **Status:** ✅ Merged **Merged:** 8/28/2024 **Merged by:** [@crobibero](https://github.com/crobibero) **Base:** `release-10.9.z` ← **Head:** `fix-profiles` --- ### 📝 Commits (2) - [`9f1df1e`](https://github.com/jellyfin/jellyfin/commit/9f1df1e02965a7c4e07271daa4c64c779f1c09ad) Fix CodecProfiles not taking effect during transcoding - [`7bd971f`](https://github.com/jellyfin/jellyfin/commit/7bd971ffefe983a1f32836b0f2fcbe602f92efa0) Only apply known video encoder profiles ### 📊 Changes **2 files changed** (+22 additions, -3 deletions) <details> <summary>View changed files</summary> 📝 `MediaBrowser.Controller/MediaEncoding/EncodingHelper.cs` (+20 -1) 📝 `MediaBrowser.Model/Dlna/StreamBuilder.cs` (+2 -2) </details> ### 📄 Description **Changes** - Fix CodecProfiles not taking effect during transcoding Fixed the issue where only `CodecProfiles` **matching the source** video codec were applied during transcoding. The target codec of the transcoding is not necessarily the same as the source codec. Partically reverts #9723, because [this line](https://github.com/jellyfin/jellyfin/pull/9723/files#diff-bde118dfa6110f699ead01698c41be0bb9b4b7690a4a0adaf62ad0697ef61d69R749) already fixed the issue described in #9411 --- - Only apply known video encoder profiles To avoid passing invalid profiles to ffmpeg. **Issues** - https://github.com/jellyfin/jellyfin-androidtv/pull/3933 --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
OVERLORD added the pull-request label 2026-02-07 07:09:23 +03:00
Sign in to join this conversation.
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: starred/jellyfin#13236