starred/jellyfin
1
0
Fork 0
mirror of https://github.com/jellyfin/jellyfin.git synced 2026-07-16 05:43:54 +03:00
Code Issues 822 Packages Projects Releases 17 Wiki Activity

[PR #12479] [MERGED] Add subtitle parser errors to log if available #13210

New Issue
Closed
opened 2026-02-07 07:09:00 +03:00 by OVERLORD · 0 comments
OVERLORD commented 2026-02-07 07:09:00 +03:00
Owner
Copy Link

📋 Pull Request Information

Original PR: https://github.com/jellyfin/jellyfin/pull/12479
Author: @pret0rian
Created: 8/20/2024
Status: ✅ Merged
Merged: 9/6/2024
Merged by: @crobibero

Base: master ← Head: add-subtitle-parser-error-log

📝 Commits (3)

  • 056c831 Add subtitle parser errors if available
  • 3b2e36e add comment
  • 077ba0d use IsNullOrWhiteSpace instead of null check

📊 Changes

3 files changed (+47 additions, -6 deletions)

View changed files

📝 CONTRIBUTORS.md (+1 -0)
📝 MediaBrowser.MediaEncoding/Subtitles/SubtitleEditParser.cs (+17 -6)
➕ MediaBrowser.MediaEncoding/Subtitles/SubtitleFormatExtensions.cs (+29 -0)

📄 Description

Changes

Add errors from subtitle parsing if they are available.

Issues

For easier debugging of many subtitle-related issues.

🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/jellyfin/jellyfin/pull/12479 **Author:** [@pret0rian](https://github.com/pret0rian) **Created:** 8/20/2024 **Status:** ✅ Merged **Merged:** 9/6/2024 **Merged by:** [@crobibero](https://github.com/crobibero) **Base:** `master` ← **Head:** `add-subtitle-parser-error-log` --- ### 📝 Commits (3) - [`056c831`](https://github.com/jellyfin/jellyfin/commit/056c831d254f7e7ab7305fce0f5bead3d480d050) Add subtitle parser errors if available - [`3b2e36e`](https://github.com/jellyfin/jellyfin/commit/3b2e36e62303afe009e201a3f2e2a33dcc6b3174) add comment - [`077ba0d`](https://github.com/jellyfin/jellyfin/commit/077ba0d61fe4093316a56a72f1fc3dea3fb76886) use IsNullOrWhiteSpace instead of null check ### 📊 Changes **3 files changed** (+47 additions, -6 deletions) <details> <summary>View changed files</summary> 📝 `CONTRIBUTORS.md` (+1 -0) 📝 `MediaBrowser.MediaEncoding/Subtitles/SubtitleEditParser.cs` (+17 -6) ➕ `MediaBrowser.MediaEncoding/Subtitles/SubtitleFormatExtensions.cs` (+29 -0) </details> ### 📄 Description <!-- Ensure your title is short, descriptive, and in the imperative mood (Fix X, Change Y, instead of Fixed X, Changed Y). For a good inspiration of what to write in commit messages and PRs please review https://chris.beams.io/posts/git-commit/ and our documentation. --> **Changes** <!-- Describe your changes here in 1-5 sentences. --> Add errors from subtitle parsing if they are available. **Issues** <!-- Tag any issues that this PR solves here. ex. Fixes # --> For easier debugging of many subtitle-related issues. --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
OVERLORD added the pull-request label 2026-02-07 07:09:00 +03:00
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
EFjellyfin.db
area:database
awaiting-feedback
backend
blocked
breaking change: web api
bug
build
ci
confirmed
discussion needed
dotnet future
downstream
duplicate
enhancement
feature
future
github-actions
good first issue
hdr
help wanted
invalid
investigation
librarydb
live-tv
lyrics
media playback
music
needs testing
nuget
performance
platform
pull-request
Mirrored from GitHub Pull Request
 question
regression
release critical
requires-web
roadmap
security
security
stale
support
syncplay
ui & ux
upstream
wontfix
No Label pull-request
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
OVERLORD
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: starred/jellyfin#13210
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?