[PR #12442] [CLOSED] Properly handle null values in PlaylistManager.cs #13197

New Issue

OVERLORD · 2026-02-07T07:08:48+03:00

OVERLORD commented

2026-02-07 07:08:48 +03:00

📋 Pull Request Information

Original PR: https://github.com/jellyfin/jellyfin/pull/12442
Author: @phito
Created: 8/13/2024
Status: ❌ Closed

Base: master ← Head: bugfix/11854-playlistmanager-handle-null-values

📝 Commits (2)

095cc80 properly handle null values in PlaylistManager.cs
01aaddd Handle null playlist after update

📊 Changes

3 files changed (+42 additions, -14 deletions)

View changed files

📝 CONTRIBUTORS.md (+1 -0)
📝 Emby.Server.Implementations/Playlists/PlaylistManager.cs (+38 -11)
📝 MediaBrowser.Controller/Playlists/IPlaylistManager.cs (+3 -3)

📄 Description

PlaylistManager.cs had a #nullable disable declaration, which lead to NullReferenceException when dependencies are return null values.

Changes
Removed #nullable disable and properly handling null values in PlaylistManager.cs.

Issues
529d24ec30

#11854 was definitely cause by this, and I believe it has already been fixed by this commit, but it did not address the root cause.

(this is also practice for my first contribution, thanks all of you for this awesome software, I am looking forward to contribute more)

_{🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.}

## 📋 Pull Request Information **Original PR:** https://github.com/jellyfin/jellyfin/pull/12442 **Author:** [@phito](https://github.com/phito) **Created:** 8/13/2024 **Status:** ❌ Closed **Base:** `master` ← **Head:** `bugfix/11854-playlistmanager-handle-null-values` --- ### 📝 Commits (2) - [`095cc80`](https://github.com/jellyfin/jellyfin/commit/095cc801e287c87d93a12f793b6eb78b3edbb492) properly handle null values in PlaylistManager.cs - [`01aaddd`](https://github.com/jellyfin/jellyfin/commit/01aaddd7eb1764f70635e990e43d745743034938) Handle null playlist after update ### 📊 Changes **3 files changed** (+42 additions, -14 deletions) <details> <summary>View changed files</summary> 📝 `CONTRIBUTORS.md` (+1 -0) 📝 `Emby.Server.Implementations/Playlists/PlaylistManager.cs` (+38 -11) 📝 `MediaBrowser.Controller/Playlists/IPlaylistManager.cs` (+3 -3) </details> ### 📄 Description `PlaylistManager.cs` had a #nullable disable declaration, which lead to NullReferenceException when dependencies are return null values. **Changes** Removed `#nullable disable` and properly handling null values in `PlaylistManager.cs`. **Issues** 529d24ec308645e92839b216fd0b52acd4ad62a2 #11854 was definitely cause by this, and I believe it has already been fixed by [this commit](https://github.com/jellyfin/jellyfin/commit/529d24ec308645e92839b216fd0b52acd4ad62a2), but it did not address the root cause. (this is also practice for my first contribution, thanks all of you for this awesome software, I am looking forward to contribute more) --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>

OVERLORD added the pull-request label 2026-02-07 07:08:48 +03:00

OVERLORD closed this issue

2026-02-07 07:08:49 +03:00

Sign in to join this conversation.

Branches Tags

master

renovate/major-skiasharp-monorepo

renovate/sharpcompress-0.x

renovate/svg.skia-5.x

renovate/ghcr.io-devcontainers-features-docker-in-docker-4.x

release-10.11.z

standards-fix

release-10.9.z

openapi-cache

release-10.10.z

explicit-load

explicit-load-v2

feature/entity-framework

only-count-folder-item

fix/ci-workflow-refactor

release-10.8.z

release-10.7.z

EraYaN-add-management-interface

release-10.6.z

release-10.5.z

release-10.4.z

release-10.3.z

release-10.2.z

release-10.1.0

1 Participants

Notifications

Due Date

No due date set.

Dependencies

No dependencies set.

Reference: starred/jellyfin#13197