starred/jellyfin
1
0
Fork 0
mirror of https://github.com/jellyfin/jellyfin.git synced 2026-07-16 05:43:54 +03:00
Code Issues 822 Packages Projects Releases 17 Wiki Activity

[PR #12428] [MERGED] Remove unused encoders #13195

New Issue
Closed
opened 2026-02-07 07:08:45 +03:00 by OVERLORD · 0 comments
OVERLORD commented 2026-02-07 07:08:45 +03:00
Owner
Copy Link

📋 Pull Request Information

Original PR: https://github.com/jellyfin/jellyfin/pull/12428
Author: @gnattu
Created: 8/11/2024
Status: ✅ Merged
Merged: 8/12/2024
Merged by: @Bond-009

Base: master ← Head: remove-unused-encoders

📝 Commits (6)

  • 1f819d3 Remove VPx encoders
  • 058a3dc Remove legacy encoders
  • a3ebbab Update api doc to remove outdated info
  • 26489c4 Remove container guessing doc from hls
  • 2321866 Remove more outdated options.
  • 447dd3a Use Math.Min

📊 Changes

5 files changed (+24 additions, -165 deletions)

View changed files

📝 Jellyfin.Api/Controllers/AudioController.cs (+4 -4)
📝 Jellyfin.Api/Controllers/DynamicHlsController.cs (+14 -14)
📝 Jellyfin.Api/Controllers/VideosController.cs (+4 -4)
📝 MediaBrowser.Controller/MediaEncoding/EncodingHelper.cs (+2 -139)
📝 MediaBrowser.MediaEncoding/Encoder/EncoderValidator.cs (+0 -4)

📄 Description

Changes

Removes the old code paths for the encoders that we are not really supporting. This includes:

  • libvpx based encoders, like vp8 and vp9
  • mpeg4 encoders
  • WMA and WMV encoders
  • libtheora encoder

None of these encoders have ever implemented a hardware acceleration path and are not truly supported by us. The current parameters for these encoders might also be incorrect, which could cause confusion for users who craft special API requests using these encoders. Removing them to reduce confusion and send a clear message that these encoders are not supported.

Issues

🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/jellyfin/jellyfin/pull/12428 **Author:** [@gnattu](https://github.com/gnattu) **Created:** 8/11/2024 **Status:** ✅ Merged **Merged:** 8/12/2024 **Merged by:** [@Bond-009](https://github.com/Bond-009) **Base:** `master` ← **Head:** `remove-unused-encoders` --- ### 📝 Commits (6) - [`1f819d3`](https://github.com/jellyfin/jellyfin/commit/1f819d3382fe360588c50744f393a4803717425d) Remove VPx encoders - [`058a3dc`](https://github.com/jellyfin/jellyfin/commit/058a3dcc6a90bc72e2bf535091348bf2eae6fa34) Remove legacy encoders - [`a3ebbab`](https://github.com/jellyfin/jellyfin/commit/a3ebbabf9552bb2c8867a350965bf7901322a62b) Update api doc to remove outdated info - [`26489c4`](https://github.com/jellyfin/jellyfin/commit/26489c4908a5752c3243e828b368a3612f8b59cd) Remove container guessing doc from hls - [`2321866`](https://github.com/jellyfin/jellyfin/commit/232186630241fc40f5e0d5c6af9e323cf85aed65) Remove more outdated options. - [`447dd3a`](https://github.com/jellyfin/jellyfin/commit/447dd3aed775f37ae97ddbab9e04a8281f1b389a) Use Math.Min ### 📊 Changes **5 files changed** (+24 additions, -165 deletions) <details> <summary>View changed files</summary> 📝 `Jellyfin.Api/Controllers/AudioController.cs` (+4 -4) 📝 `Jellyfin.Api/Controllers/DynamicHlsController.cs` (+14 -14) 📝 `Jellyfin.Api/Controllers/VideosController.cs` (+4 -4) 📝 `MediaBrowser.Controller/MediaEncoding/EncodingHelper.cs` (+2 -139) 📝 `MediaBrowser.MediaEncoding/Encoder/EncoderValidator.cs` (+0 -4) </details> ### 📄 Description <!-- Ensure your title is short, descriptive, and in the imperative mood (Fix X, Change Y, instead of Fixed X, Changed Y). For a good inspiration of what to write in commit messages and PRs please review https://chris.beams.io/posts/git-commit/ and our documentation. --> **Changes** <!-- Describe your changes here in 1-5 sentences. --> Removes the old code paths for the encoders that we are not really supporting. This includes: - libvpx based encoders, like vp8 and vp9 - mpeg4 encoders - WMA and WMV encoders - libtheora encoder None of these encoders have ever implemented a hardware acceleration path and are not truly supported by us. The current parameters for these encoders might also be incorrect, which could cause confusion for users who craft special API requests using these encoders. Removing them to reduce confusion and send a clear message that these encoders are not supported. **Issues** <!-- Tag any issues that this PR solves here. ex. Fixes # --> --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
OVERLORD added the pull-request label 2026-02-07 07:08:45 +03:00
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
EFjellyfin.db
area:database
awaiting-feedback
backend
blocked
breaking change: web api
bug
build
ci
confirmed
discussion needed
dotnet future
downstream
duplicate
enhancement
feature
future
github-actions
good first issue
hdr
help wanted
invalid
investigation
librarydb
live-tv
lyrics
media playback
music
needs testing
nuget
performance
platform
pull-request
Mirrored from GitHub Pull Request
 question
regression
release critical
requires-web
roadmap
security
security
stale
support
syncplay
ui & ux
upstream
wontfix
No Label pull-request
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
OVERLORD
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: starred/jellyfin#13195
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?