[PR #12369] [MERGED] Enable more analyser rules as errors #13165

Closed
opened 2026-02-07 07:08:16 +03:00 by OVERLORD · 0 comments
Owner

📋 Pull Request Information

Original PR: https://github.com/jellyfin/jellyfin/pull/12369
Author: @Bond-009
Created: 8/1/2024
Status: Merged
Merged: 8/2/2024
Merged by: @Bond-009

Base: masterHead: warn


📝 Commits (1)

  • 0a0de67 Enable more analyser rules as errors

📊 Changes

5 files changed (+66 additions, -45 deletions)

View changed files

📝 Emby.Naming/TV/SeasonPathParser.cs (+6 -9)
📝 MediaBrowser.Model/Dlna/StreamBuilder.cs (+1 -1)
📝 jellyfin.ruleset (+22 -0)
tests/Jellyfin.Naming.Tests/TV/SeasonFolderTests.cs (+0 -35)
tests/Jellyfin.Naming.Tests/TV/SeasonPathParserTests.cs (+37 -0)

📄 Description

Also deduplicates a bit of code inside of SeasonPathParser and adds some more tests


🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/jellyfin/jellyfin/pull/12369 **Author:** [@Bond-009](https://github.com/Bond-009) **Created:** 8/1/2024 **Status:** ✅ Merged **Merged:** 8/2/2024 **Merged by:** [@Bond-009](https://github.com/Bond-009) **Base:** `master` ← **Head:** `warn` --- ### 📝 Commits (1) - [`0a0de67`](https://github.com/jellyfin/jellyfin/commit/0a0de6708e0b900ca616b108dfdf94894a56a6e0) Enable more analyser rules as errors ### 📊 Changes **5 files changed** (+66 additions, -45 deletions) <details> <summary>View changed files</summary> 📝 `Emby.Naming/TV/SeasonPathParser.cs` (+6 -9) 📝 `MediaBrowser.Model/Dlna/StreamBuilder.cs` (+1 -1) 📝 `jellyfin.ruleset` (+22 -0) ➖ `tests/Jellyfin.Naming.Tests/TV/SeasonFolderTests.cs` (+0 -35) ➕ `tests/Jellyfin.Naming.Tests/TV/SeasonPathParserTests.cs` (+37 -0) </details> ### 📄 Description Also deduplicates a bit of code inside of SeasonPathParser and adds some more tests --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
OVERLORD added the pull-request label 2026-02-07 07:08:16 +03:00
Sign in to join this conversation.
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: starred/jellyfin#13165