mirror of
https://github.com/jellyfin/jellyfin.git
synced 2026-07-16 05:43:54 +03:00
[PR #12330] [CLOSED] Reverse textless images above English images #13147
Reference in New Issue
Block a user
Delete Branch "%!s()"
Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?
📋 Pull Request Information
Original PR: https://github.com/jellyfin/jellyfin/pull/12330
Author: @ikheetjeff
Created: 7/24/2024
Status: ❌ Closed
Base:
master← Head:reverse-prioritize-matching-image-language📝 Commits (1)
4b45abfReverse non-text images above English images📊 Changes
1 file changed (+7 additions, -10 deletions)
View changed files
📝
MediaBrowser.Model/Extensions/EnumerableExtensions.cs(+7 -10)📄 Description
In version 10.8.13, when searching for images, a poster in the set language is searched for first. If that is not found, it falls back to the English version.
In newer versions, preference is now given to textless images. This more often results in incorrect images and, in my opinion, compromises quality.
Even when the preferred language is set to English, it chooses the textless poster instead of the English version.
Examples:
Non-text: https://image.tmdb.org/t/p/original/knVvNKM5JGJsMFGDAIJ3F3TF8iX.jpg
English: https://image.tmdb.org/t/p/original/AewKpiZ76mLTnr8dx9skROzMX7P.jpg
English: https://image.tmdb.org/t/p/original/zP4CK9O70P8GDilfTkPm4lrmaks.jpg
non-text: https://image.tmdb.org/t/p/original/jHHpEnAGdDAnbJI2o4o4IYHldGL.jpg
I understand that this is a subjective topic. In some countries, dubbing is more standard, while in other countries, subtitles are preferred. However, the local version is often available.
English is a global language, and it seems more logical to fall back on it rather than on textless images. These images are often unclear, making it difficult to see which series or film it is. And that seems to defeat the purpose of a poster. (And manually changing each poster to the English version every time is not something I am keen on either.)
The best solution would be a fallback image language option. I don't have enough experience to create this myself, and I personally find English more important than textless images. Therefore, I propose this rollback. Full credit goes to whoever wrote this code before this PR.
I have researched whether this topic has been addressed before. I couldn't find anything. My apologies if this is incorrect and it is indeed a deliberate choice. - Feedback is also always welcome.
🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.