starred/jellyfin
1
0
Fork 0
mirror of https://github.com/jellyfin/jellyfin.git synced 2026-07-16 05:43:54 +03:00
Code Issues 822 Packages Projects Releases 17 Wiki Activity

[PR #12245] [CLOSED] Broken Image Downloads for Azure Storage files. #13115

New Issue
Closed
opened 2026-02-07 07:07:23 +03:00 by OVERLORD · 0 comments
OVERLORD commented 2026-02-07 07:07:23 +03:00
Owner
Copy Link

📋 Pull Request Information

Original PR: https://github.com/jellyfin/jellyfin/pull/12245
Author: @mjohl
Created: 7/9/2024
Status: ❌ Closed

Base: master ← Head: fix_broken_image_downloads_to_cache

📝 Commits (3)

  • 353d6d4 Fixed an annoying exception in the log that made it far bigger than needed. As I was here, fixed the root cause for the exception as well.
  • 1f2efd1 Redundant if removed and log level set to match caller. Boilerplate comments removed.
  • 3eb70e4 Swtich replaced with GetMimeType utility method

📊 Changes

3 files changed (+36 additions, -10 deletions)

View changed files

📝 Emby.Server.Implementations/Library/LibraryManager.cs (+18 -9)
📝 Jellyfin.Api/Controllers/ImageController.cs (+9 -1)
📝 MediaBrowser.Providers/Manager/ProviderManager.cs (+9 -0)

📄 Description

Changes

  • Improved error handling on image download failures to prevent log flooding and provide more info about the status code from the source.
  • Addition to the SaveImage method to handle application/octet-stream from Azure Blob Storage when providers do not set the content type.

Issues
#12143

Pre-Change
Screenshot 2024-07-07 164602

Post-Change
Screenshot 2024-07-07 164921

🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/jellyfin/jellyfin/pull/12245 **Author:** [@mjohl](https://github.com/mjohl) **Created:** 7/9/2024 **Status:** ❌ Closed **Base:** `master` ← **Head:** `fix_broken_image_downloads_to_cache` --- ### 📝 Commits (3) - [`353d6d4`](https://github.com/jellyfin/jellyfin/commit/353d6d4a57f4096073fa5bc404a68fa252e29869) Fixed an annoying exception in the log that made it far bigger than needed. As I was here, fixed the root cause for the exception as well. - [`1f2efd1`](https://github.com/jellyfin/jellyfin/commit/1f2efd1505e20c5299b8b0d3efbd25316975088c) Redundant if removed and log level set to match caller. Boilerplate comments removed. - [`3eb70e4`](https://github.com/jellyfin/jellyfin/commit/3eb70e4ef30d6b3c19f629df14b03f86911d2348) Swtich replaced with GetMimeType utility method ### 📊 Changes **3 files changed** (+36 additions, -10 deletions) <details> <summary>View changed files</summary> 📝 `Emby.Server.Implementations/Library/LibraryManager.cs` (+18 -9) 📝 `Jellyfin.Api/Controllers/ImageController.cs` (+9 -1) 📝 `MediaBrowser.Providers/Manager/ProviderManager.cs` (+9 -0) </details> ### 📄 Description <!-- Ensure your title is short, descriptive, and in the imperative mood (Fix X, Change Y, instead of Fixed X, Changed Y). For a good inspiration of what to write in commit messages and PRs please review https://chris.beams.io/posts/git-commit/ and our documentation. --> **Changes** - Improved error handling on image download failures to prevent log flooding and provide more info about the status code from the source. - Addition to the SaveImage method to handle application/octet-stream from Azure Blob Storage when providers do not set the content type. **Issues** #12143 Pre-Change ![Screenshot 2024-07-07 164602](https://github.com/jellyfin/jellyfin/assets/4193377/a02bfa96-0616-4444-9a33-cf3d37eb1d42) Post-Change ![Screenshot 2024-07-07 164921](https://github.com/jellyfin/jellyfin/assets/4193377/492d7f9a-477e-406d-920b-2ca78c03c713) --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
OVERLORD added the pull-request label 2026-02-07 07:07:23 +03:00
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
EFjellyfin.db
area:database
awaiting-feedback
backend
blocked
breaking change: web api
bug
build
ci
confirmed
discussion needed
dotnet future
downstream
duplicate
enhancement
feature
future
github-actions
good first issue
hdr
help wanted
invalid
investigation
librarydb
live-tv
lyrics
media playback
music
needs testing
nuget
performance
platform
pull-request
Mirrored from GitHub Pull Request
 question
regression
release critical
requires-web
roadmap
security
security
stale
support
syncplay
ui & ux
upstream
wontfix
No Label pull-request
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
OVERLORD
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: starred/jellyfin#13115
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?