starred/jellyfin
1
0
Fork 0
mirror of https://github.com/jellyfin/jellyfin.git synced 2026-07-16 05:43:54 +03:00
Code Issues 822 Packages Projects Releases 17 Wiki Activity

[PR #11743] Fix replace logic #12982

New Issue
Closed
opened 2026-02-07 07:05:10 +03:00 by OVERLORD · 0 comments
OVERLORD commented 2026-02-07 07:05:10 +03:00
Owner
Copy Link

Original Pull Request: https://github.com/jellyfin/jellyfin/pull/11743

State: closed
Merged: Yes

We never passed the flag for metadata replacement to the remote provider logic, hence the remote result would never replace what's already there.
Additionally, the logic did not repect if an item was locked or not

Changes

  • Pass replace flag to remote providers
  • Fix merge logic to only override empty fields, except when merging with the actual item
    • this will gradually build up metadata beginning with local providers and going through remote providers later on

Issues
Fixes #8532 (potentially)
Fixes #11294 (the part where it is repopulated)
Fixes #11656
Fixes #11717
Fixes #11773 (potentially)
Fixes #11831

Testing

  • Add series, manually remove some metadata and replace all metadata -> should refill
  • Add series, manually remove some metadata and fetch missing metadata -> should refill
  • Add series, manually identify, remove some metadata and replace metadata -> should keep identified series
  • Any other combination of the above and with replace images
**Original Pull Request:** https://github.com/jellyfin/jellyfin/pull/11743 **State:** closed **Merged:** Yes --- We never passed the flag for metadata replacement to the remote provider logic, hence the remote result would never replace what's already there. Additionally, the logic did not repect if an item was locked or not **Changes** * Pass replace flag to remote providers * Fix merge logic to only override empty fields, except when merging with the actual item * this will gradually build up metadata beginning with local providers and going through remote providers later on **Issues** Fixes #8532 (potentially) Fixes #11294 (the part where it is repopulated) Fixes #11656 Fixes #11717 Fixes #11773 (potentially) Fixes #11831 **Testing** * Add series, manually remove some metadata and replace all metadata -> should refill * Add series, manually remove some metadata and fetch missing metadata -> should refill * Add series, manually identify, remove some metadata and replace metadata -> should keep identified series * Any other combination of the above and with replace images
OVERLORD added the pull-request label 2026-02-07 07:05:10 +03:00
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
EFjellyfin.db
area:database
awaiting-feedback
backend
blocked
breaking change: web api
bug
build
ci
confirmed
discussion needed
dotnet future
downstream
duplicate
enhancement
feature
future
github-actions
good first issue
hdr
help wanted
invalid
investigation
librarydb
live-tv
lyrics
media playback
music
needs testing
nuget
performance
platform
pull-request
Mirrored from GitHub Pull Request
 question
regression
release critical
requires-web
roadmap
security
security
stale
support
syncplay
ui & ux
upstream
wontfix
No Label pull-request
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
OVERLORD
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: starred/jellyfin#12982
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?