mirror of
https://github.com/jellyfin/jellyfin.git
synced 2026-07-16 05:43:54 +03:00
[PR #11674] fix: keep current season name if no override exists #12968
Reference in New Issue
Block a user
Delete Branch "%!s()"
Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?
Original Pull Request: https://github.com/jellyfin/jellyfin/pull/11674
State: closed
Merged: No
Changes
TL;DR: Keep the season name if the no override exists for the season.
Longer version:
So my plugin uses custom season names — which have worked fine throughout all of 10.8's lifecycle — but after the new NFO named season parsing was added in 10.9 (21 months ago no less), then the support for custom season names provided by remote metadata plugins partially broke as a result. This simple change fixes the issue by keeping the current season name for the existing seasons but allows the NFO season names to override the name if needed/desired, thus not breaking the support for custom season names provided by remote metadata plugins that we've loved Jellyfin for so far.
Also, I did the digging and debugging to fix this before checking for existing issues, and also doesn't think the other PR addressed the root issue here, so I decided to submit this PR since I believe it fixes it.
Issues
https://github.com/jellyfin/jellyfin/issues/11655 ← Fixes this.
https://github.com/jellyfin/jellyfin/issues/11656 ← Fixes this.
https://github.com/jellyfin/jellyfin/pull/11647 ← I felt this didn't address the issue I was having, as I've been debugging Jellyfin to find out why it changed it back, and saw that PR didn't address that issue.