starred/jellyfin
1
0
Fork 0
mirror of https://github.com/jellyfin/jellyfin.git synced 2026-07-16 05:43:54 +03:00
Code Issues 822 Packages Projects Releases 17 Wiki Activity

[PR #11520] Allow absolute path mismatch when getting virtual folder info #12933

New Issue
Closed
opened 2026-02-07 07:04:20 +03:00 by OVERLORD · 0 comments
OVERLORD commented 2026-02-07 07:04:20 +03:00
Owner
Copy Link

Original Pull Request: https://github.com/jellyfin/jellyfin/pull/11520

State: closed
Merged: No

We have historically required the path stored in the database to exactly match the actual path on the filesystem to retrieve virtual folder information, dating back to the Emby era. However, this approach can cause issues when symbolic links are involved, as the link path may differ from the actual pointed path. To address this, allow matching based solely on the folder name when absolute path checking fails, mitigating such problems.

I have no idea why this works previously for 10.8 as @joshuaboniface said. The mismatching path should never worked as the code is from emby.

Changes

  • allow matching based solely on the folder name when absolute path checking fails for GetVirtualFolders

Issues

Fixes jellyfin/jellyfin#12100 Although I don't understand why it worked for 10.8

**Original Pull Request:** https://github.com/jellyfin/jellyfin/pull/11520 **State:** closed **Merged:** No --- We have historically required the path stored in the database to exactly match the actual path on the filesystem to retrieve virtual folder information, dating back to the Emby era. However, this approach can cause issues when symbolic links are involved, as the link path may differ from the actual pointed path. To address this, allow matching based solely on the folder name when absolute path checking fails, mitigating such problems. I have no idea why this works previously for 10.8 as @joshuaboniface said. The mismatching path should never worked as the code is from emby. <!-- Ensure your title is short, descriptive, and in the imperative mood (Fix X, Change Y, instead of Fixed X, Changed Y). For a good inspiration of what to write in commit messages and PRs please review https://chris.beams.io/posts/git-commit/ and our documentation. --> **Changes** <!-- Describe your changes here in 1-5 sentences. --> - allow matching based solely on the folder name when absolute path checking fails for `GetVirtualFolders` **Issues** <!-- Tag any issues that this PR solves here. ex. Fixes # --> Fixes jellyfin/jellyfin#12100 Although I don't understand why it worked for 10.8
OVERLORD added the pull-request label 2026-02-07 07:04:20 +03:00
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
EFjellyfin.db
area:database
awaiting-feedback
backend
blocked
breaking change: web api
bug
build
ci
confirmed
discussion needed
dotnet future
downstream
duplicate
enhancement
feature
future
github-actions
good first issue
hdr
help wanted
invalid
investigation
librarydb
live-tv
lyrics
media playback
music
needs testing
nuget
performance
platform
pull-request
Mirrored from GitHub Pull Request
 question
regression
release critical
requires-web
roadmap
security
security
stale
support
syncplay
ui & ux
upstream
wontfix
No Label pull-request
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
OVERLORD
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: starred/jellyfin#12933
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?