[PR #11468] More efficient array creation #12907

New Issue

OVERLORD · 2026-02-07T07:03:53+03:00

OVERLORD commented

2026-02-07 07:03:53 +03:00

Original Pull Request: https://github.com/jellyfin/jellyfin/pull/11468

State: closed
Merged: Yes

Use new collection expressions to concat to existing arrays
Use Array.ConvertAll where possible
Replace .ToArray with .ToList where possible

(And yes, collection expressions are as fast/faster than manually creating and copying)

| Method | N    | Mean       | Error     | StdDev    | Gen0   | Allocated |
|------- |----- |-----------:|----------:|----------:|-------:|----------:|
| Magic  | 0    |   9.943 ns | 0.0780 ns | 0.0692 ns | 0.0004 |      32 B |
| Manual | 0    |  14.550 ns | 0.0883 ns | 0.0826 ns | 0.0004 |      32 B |
| Magic  | 1    |  10.365 ns | 0.0529 ns | 0.0494 ns | 0.0004 |      32 B |
| Manual | 1    |  15.433 ns | 0.1458 ns | 0.1364 ns | 0.0004 |      32 B |
| Magic  | 4    |  11.119 ns | 0.0906 ns | 0.0803 ns | 0.0004 |      32 B |
| Manual | 4    |  15.586 ns | 0.1641 ns | 0.1370 ns | 0.0004 |      32 B |
| Magic  | 64   |  15.337 ns | 0.0777 ns | 0.0649 ns | 0.0011 |      96 B |
| Manual | 64   |  20.924 ns | 0.2432 ns | 0.2275 ns | 0.0011 |      96 B |
| Magic  | 512  |  53.652 ns | 0.5195 ns | 0.4860 ns | 0.0065 |     544 B |
| Manual | 512  |  58.823 ns | 0.4412 ns | 0.3911 ns | 0.0064 |     544 B |
| Magic  | 2048 | 187.799 ns | 2.6503 ns | 2.4791 ns | 0.0248 |    2080 B |
| Manual | 2048 | 197.916 ns | 1.4985 ns | 1.4017 ns | 0.0248 |    2080 B |

**Original Pull Request:** https://github.com/jellyfin/jellyfin/pull/11468 **State:** closed **Merged:** Yes --- * Use new collection expressions to concat to existing arrays * Use Array.ConvertAll where possible * Replace .ToArray with .ToList where possible (And yes, collection expressions are as fast/faster than manually creating and copying) ``` | Method | N | Mean | Error | StdDev | Gen0 | Allocated | |------- |----- |-----------:|----------:|----------:|-------:|----------:| | Magic | 0 | 9.943 ns | 0.0780 ns | 0.0692 ns | 0.0004 | 32 B | | Manual | 0 | 14.550 ns | 0.0883 ns | 0.0826 ns | 0.0004 | 32 B | | Magic | 1 | 10.365 ns | 0.0529 ns | 0.0494 ns | 0.0004 | 32 B | | Manual | 1 | 15.433 ns | 0.1458 ns | 0.1364 ns | 0.0004 | 32 B | | Magic | 4 | 11.119 ns | 0.0906 ns | 0.0803 ns | 0.0004 | 32 B | | Manual | 4 | 15.586 ns | 0.1641 ns | 0.1370 ns | 0.0004 | 32 B | | Magic | 64 | 15.337 ns | 0.0777 ns | 0.0649 ns | 0.0011 | 96 B | | Manual | 64 | 20.924 ns | 0.2432 ns | 0.2275 ns | 0.0011 | 96 B | | Magic | 512 | 53.652 ns | 0.5195 ns | 0.4860 ns | 0.0065 | 544 B | | Manual | 512 | 58.823 ns | 0.4412 ns | 0.3911 ns | 0.0064 | 544 B | | Magic | 2048 | 187.799 ns | 2.6503 ns | 2.4791 ns | 0.0248 | 2080 B | | Manual | 2048 | 197.916 ns | 1.4985 ns | 1.4017 ns | 0.0248 | 2080 B | ```

OVERLORD added the pull-request label 2026-02-07 07:03:53 +03:00

OVERLORD closed this issue

2026-02-07 07:03:54 +03:00

OVERLORD referenced this issue

2026-02-07 07:12:23 +03:00

[PR #12907] [MERGED] Fix stackoverflow in MediaSourceCount #13408

OVERLORD referenced this issue

2026-02-07 07:24:39 +03:00

[PR #14783] [MERGED] Fix several Stackoverflows #14113

Sign in to join this conversation.