mirror of
https://github.com/jellyfin/jellyfin.git
synced 2026-07-16 05:43:54 +03:00
[PR #11246] fix: unset qmin and qmax for vt #12816
Reference in New Issue
Block a user
Delete Branch "%!s()"
Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?
Original Pull Request: https://github.com/jellyfin/jellyfin/pull/11246
State: closed
Merged: Yes
Changes
We are using bitrate-based control, but VT will target qmax first, potentially making the video bitrate much higher than the limit when the limit is very low and the video resolution is very high. Unset it so that the bitrate is close to the target.
In this case, even the
-maxratesetting will have no effect on the bitrate. It only reduces the performance, but the result bitrate is still much higher than the limit.Other encoders potentially have same issue, but most of them is already patched in some other way, like very high qmax or using CBR.
Ideally, we should perform a video resolution downscale when the bitrate limit is too low for the resolution to preserve better visual quality. However, this use case could be very edgey, such as attempting to stream 4K60 video over a 5Mbps network, so probably not worth the effort.
Issues