starred/jellyfin
1
0
Fork 0
mirror of https://github.com/jellyfin/jellyfin.git synced 2026-07-16 05:43:54 +03:00
Code Issues 822 Packages Projects Releases 17 Wiki Activity

[PR #11245] fix: add image count check to splash screen generation #12808

New Issue
Closed
opened 2026-02-07 07:02:06 +03:00 by OVERLORD · 0 comments
OVERLORD commented 2026-02-07 07:02:06 +03:00
Owner
Copy Link

Original Pull Request: https://github.com/jellyfin/jellyfin/pull/11245

State: closed
Merged: Yes

Changes
This check will prevent the splash screen generation from running if we have no posters or no backdrops/thumbnails to generate a splash screen from. Since even if it ran it would just err out when it tried to retrieve the missing poster/backdrop/thumbnail.

I added the check inside SkiaEncoder.CreateSplashscreen to stop it from running if somebody tried to create a splash screen regardless of where the IImageEncoder.CreateSplashscreen might be called from. If you want me to move the check to the SplashscreenPostScanTask instead, to prevent it from running even if we change the underlying implementation of the IImageEncoder in the future, then just say the word.

Issues

**Original Pull Request:** https://github.com/jellyfin/jellyfin/pull/11245 **State:** closed **Merged:** Yes --- <!-- Ensure your title is short, descriptive, and in the imperative mood (Fix X, Change Y, instead of Fixed X, Changed Y). For a good inspiration of what to write in commit messages and PRs please review https://chris.beams.io/posts/git-commit/ and our documentation. --> **Changes** This check will prevent the splash screen generation from running if we have no posters or no backdrops/thumbnails to generate a splash screen from. Since even if it ran it would just err out when it tried to retrieve the missing poster/backdrop/thumbnail. I added the check inside `SkiaEncoder.CreateSplashscreen` to stop it from running if somebody tried to create a splash screen regardless of where the `IImageEncoder.CreateSplashscreen` might be called from. If you want me to move the check to the `SplashscreenPostScanTask` instead, to prevent it from running even if we change the underlying implementation of the `IImageEncoder` in the future, then just say the word. **Issues** <!-- Tag any issues that this PR solves here. ex. Fixes # -->
OVERLORD added the pull-request label 2026-02-07 07:02:06 +03:00
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
EFjellyfin.db
area:database
awaiting-feedback
backend
blocked
breaking change: web api
bug
build
ci
confirmed
discussion needed
dotnet future
downstream
duplicate
enhancement
feature
future
github-actions
good first issue
hdr
help wanted
invalid
investigation
librarydb
live-tv
lyrics
media playback
music
needs testing
nuget
performance
platform
pull-request
Mirrored from GitHub Pull Request
 question
regression
release critical
requires-web
roadmap
security
security
stale
support
syncplay
ui & ux
upstream
wontfix
No Label pull-request
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
OVERLORD
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: starred/jellyfin#12808
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?