starred/jellyfin
1
0
Fork 0
mirror of https://github.com/jellyfin/jellyfin.git synced 2026-07-16 05:43:54 +03:00
Code Issues 822 Packages Projects Releases 17 Wiki Activity

[PR #11161] Fix the fragile segment deletion #12757

New Issue
Closed
opened 2026-02-07 07:01:18 +03:00 by OVERLORD · 0 comments
OVERLORD commented 2026-02-07 07:01:18 +03:00
Owner
Copy Link

Original Pull Request: https://github.com/jellyfin/jellyfin/pull/11161

State: closed
Merged: Yes

Changes

  • Add TranscodingSegmentCleaner to replace ffmpeg's hlsenc deletion

FFmpeg deletes segments based on its own transcoding progress,
but we need to delete segments based on client download progress.
Since disk and GPU speeds vary, using hlsenc's built-in deletion
will result in premature deletion of some segments. As a consequence,
the server has to constantly respin new ffmpeg instances, resulting
in choppy video playback.

  • Add sanity check for ThrottleDelaySeconds
  • Set input readrate for using SegmentDeletion with stream-copy

Issues

  • The old implementation just happened to work. It's actually very fragile and can easily break playback by just entering some smaller SegmentKeepSeconds value.
**Original Pull Request:** https://github.com/jellyfin/jellyfin/pull/11161 **State:** closed **Merged:** Yes --- **Changes** - Add `TranscodingSegmentCleaner` to replace ffmpeg's hlsenc deletion FFmpeg deletes segments based on its own transcoding progress, but we need to delete segments based on client download progress. Since disk and GPU speeds vary, using hlsenc's built-in deletion will result in premature deletion of some segments. As a consequence, the server has to constantly respin new ffmpeg instances, resulting in choppy video playback. - Add sanity check for `ThrottleDelaySeconds` - Set input `readrate` for using SegmentDeletion with stream-copy **Issues** - The [old implementation](https://github.com/jellyfin/jellyfin/pull/8744) just happened to work. It's actually very fragile and can easily break playback by just entering some smaller `SegmentKeepSeconds` value.
OVERLORD added the pull-request label 2026-02-07 07:01:18 +03:00
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
EFjellyfin.db
area:database
awaiting-feedback
backend
blocked
breaking change: web api
bug
build
ci
confirmed
discussion needed
dotnet future
downstream
duplicate
enhancement
feature
future
github-actions
good first issue
hdr
help wanted
invalid
investigation
librarydb
live-tv
lyrics
media playback
music
needs testing
nuget
performance
platform
pull-request
Mirrored from GitHub Pull Request
 question
regression
release critical
requires-web
roadmap
security
security
stale
support
syncplay
ui & ux
upstream
wontfix
No Label pull-request
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
OVERLORD
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: starred/jellyfin#12757
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?