starred/jellyfin
1
0
Fork 0
mirror of https://github.com/jellyfin/jellyfin.git synced 2026-05-04 18:09:12 +03:00
Code Issues 822 Packages Projects Releases 10 Wiki Activity

[PR #10956] Fix InvalidOperationException if log file not found #12675

New Issue
Closed
opened 2026-02-07 06:59:59 +03:00 by OVERLORD · 0 comments
OVERLORD commented 2026-02-07 06:59:59 +03:00
Owner
Copy Link

Original Pull Request: https://github.com/jellyfin/jellyfin/pull/10956

State: closed
Merged: Yes

Changes

API route System/Logs/Log currently throws an InvalidOperationException and returns a 500 if the requested log file does not exist.

I updated this method to handle this edge case and reutrn a 404.

I also added unit tests to check that NotFound is returned if the file does not exist. I was going to add more unit tests for this method, but testing it is slightly difficult due to the lack of abstraction and using FileStream directly.

Issues

None

**Original Pull Request:** https://github.com/jellyfin/jellyfin/pull/10956 **State:** closed **Merged:** Yes --- <!-- Ensure your title is short, descriptive, and in the imperative mood (Fix X, Change Y, instead of Fixed X, Changed Y). For a good inspiration of what to write in commit messages and PRs please review https://chris.beams.io/posts/git-commit/ and our documentation. --> **Changes** <!-- Describe your changes here in 1-5 sentences. --> API route `System/Logs/Log` currently throws an InvalidOperationException and returns a 500 if the requested log file does not exist. I updated this method to handle this edge case and reutrn a 404. I also added unit tests to check that NotFound is returned if the file does not exist. I was going to add more unit tests for this method, but testing it is slightly difficult due to the lack of abstraction and using FileStream directly. **Issues** <!-- Tag any issues that this PR solves here. ex. Fixes # --> None
OVERLORD added the pull-request label 2026-02-07 06:59:59 +03:00
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
EFjellyfin.db
area:database
awaiting-feedback
backend
blocked
breaking change: web api
bug
build
ci
confirmed
discussion needed
dotnet future
downstream
duplicate
enhancement
feature
future
github-actions
good first issue
hdr
help wanted
invalid
investigation
librarydb
live-tv
lyrics
media playback
music
needs testing
nuget
performance
platform
pull-request
Mirrored from GitHub Pull Request
 question
regression
release critical
requires-web
roadmap
security
security
stale
support
syncplay
ui & ux
upstream
wontfix
No Label pull-request
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
OVERLORD
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: starred/jellyfin#12675
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?