starred/jellyfin
1
0
Fork 0
mirror of https://github.com/jellyfin/jellyfin.git synced 2026-05-04 18:09:12 +03:00
Code Issues 822 Packages Projects Releases 10 Wiki Activity

[PR #10801] AsyncKeyedLock migration #12615

New Issue
Closed
opened 2026-02-07 06:58:55 +03:00 by OVERLORD · 0 comments
OVERLORD commented 2026-02-07 06:58:55 +03:00
Owner
Copy Link

Original Pull Request: https://github.com/jellyfin/jellyfin/pull/10801

State: closed
Merged: Yes

Switching the existing locking mechanism to use the AsyncKeyedLock library which has been heavily tested and benchmarked, offering superior performance and lower memory allocations (mainly due to the object pooling), while extra care ensured against race conditions.

Changes
Jellyfin now uses a more streamlined approach to locking concurrent tasks by key.

Issues
Replaces #9132

Note to reviewer: there are a number of if statements that happen within the locks. I left them as is so as not to affect functionality but it is quite likely that it would be possible for you to put the if outside/enclosing the lock, leading to a performance gain. @JPVenson

**Original Pull Request:** https://github.com/jellyfin/jellyfin/pull/10801 **State:** closed **Merged:** Yes --- Switching the existing locking mechanism to use the AsyncKeyedLock library which has been heavily tested and benchmarked, offering superior performance and lower memory allocations (mainly due to the object pooling), while extra care ensured against race conditions. **Changes** Jellyfin now uses a more streamlined approach to locking concurrent tasks by key. **Issues** Replaces #9132 Note to reviewer: there are a number of `if` statements that happen within the locks. I left them as is so as not to affect functionality but it is quite likely that it would be possible for you to put the `if` outside/enclosing the lock, leading to a performance gain. @JPVenson
OVERLORD added the pull-request label 2026-02-07 06:58:55 +03:00
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
EFjellyfin.db
area:database
awaiting-feedback
backend
blocked
breaking change: web api
bug
build
ci
confirmed
discussion needed
dotnet future
downstream
duplicate
enhancement
feature
future
github-actions
good first issue
hdr
help wanted
invalid
investigation
librarydb
live-tv
lyrics
media playback
music
needs testing
nuget
performance
platform
pull-request
Mirrored from GitHub Pull Request
 question
regression
release critical
requires-web
roadmap
security
security
stale
support
syncplay
ui & ux
upstream
wontfix
No Label pull-request
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
OVERLORD
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: starred/jellyfin#12615
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?