starred/jellyfin
1
0
Fork 0
mirror of https://github.com/jellyfin/jellyfin.git synced 2026-05-04 18:09:12 +03:00
Code Issues 822 Packages Projects Releases 10 Wiki Activity

[PR #10323] Allow repeated same tv guide channels on M3U tuner #12431

New Issue
Closed
opened 2026-02-07 06:55:43 +03:00 by OVERLORD · 0 comments
OVERLORD commented 2026-02-07 06:55:43 +03:00
Owner
Copy Link

Original Pull Request: https://github.com/jellyfin/jellyfin/pull/10323

State: closed
Merged: Yes

Fixes issue #6527

Removed the the condition that checks if a channel has an id (tv guide id), it uses it as an unique id with md5 hash.
This was kinda wrong since :

  1. We can have multiple channels lines in a m3u which uses same tv guide (SD and HD version of same broadcast for example)
  2. The behavior of the code was not explicit, all the code flow kept all channels until we write them down to the database , then since they have same unique generated id , the first channel is written to the db and then the following channel with same id overwrites it.

I Thought of adding a checkbox to keep old behavior at m3u tuner level but I am quite sure the condition/old behavior is not needed and was wrong/not intended.

**Original Pull Request:** https://github.com/jellyfin/jellyfin/pull/10323 **State:** closed **Merged:** Yes --- Fixes issue #6527 Removed the the condition that checks if a channel has an id (tv guide id), it uses it as an unique id with md5 hash. This was kinda wrong since : 1. We can have multiple channels lines in a m3u which uses same tv guide (SD and HD version of same broadcast for example) 2. The behavior of the code was not explicit, all the code flow kept all channels until we write them down to the database , then since they have same unique generated id , the first channel is written to the db and then the following channel with same id overwrites it. I Thought of adding a checkbox to keep old behavior at m3u tuner level but I am quite sure the condition/old behavior is not needed and was wrong/not intended.
OVERLORD added the pull-request label 2026-02-07 06:55:43 +03:00
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
EFjellyfin.db
area:database
awaiting-feedback
backend
blocked
breaking change: web api
bug
build
ci
confirmed
discussion needed
dotnet future
downstream
duplicate
enhancement
feature
future
github-actions
good first issue
hdr
help wanted
invalid
investigation
librarydb
live-tv
lyrics
media playback
music
needs testing
nuget
performance
platform
pull-request
Mirrored from GitHub Pull Request
 question
regression
release critical
requires-web
roadmap
security
security
stale
support
syncplay
ui & ux
upstream
wontfix
No Label pull-request
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
OVERLORD
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: starred/jellyfin#12431
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?