[PR #9723] Fix multiple codec checking in CodecProfiles conditions #12203

New Issue

OVERLORD · 2026-02-07T06:51:49+03:00

OVERLORD commented

2026-02-07 06:51:49 +03:00

Original Pull Request: https://github.com/jellyfin/jellyfin/pull/9723

State: closed
Merged: Yes

ContainsAnyCodec checks if its codec list contains the specified one.
#9411 limited this check to one codec per codec profile.
However, I haven't seen us use more than one.

With something like:

{
    "Codec": "h264,hevc",
    "Container": "mkv",
    "Conditions": [
        {
            "Condition": "LessThanEqual",
            "Property": "VideoBitrate",
            "Value": "10000000",
            "IsRequired": "true"
        }
    ]
},
{
    "Codec": "h264",
    "Container": "mkv",
    "Conditions": [
        {
            "Condition": "LessThanEqual",
            "Property": "VideoLevel",
            "Value": "42",
            "IsRequired": "true"
        }
    ]
}

both conditions should apply for h264 in mkv.

Changes
Allow (bring back) a list of codecs in CodecProfiles while keeping the idea of #9411.

Issues
N/A

**Original Pull Request:** https://github.com/jellyfin/jellyfin/pull/9723 **State:** closed **Merged:** Yes --- `ContainsAnyCodec` checks if its codec list contains the specified one. #9411 limited this check to one codec per codec profile. _However, I haven't seen us use more than one._ With something like: ```json { "Codec": "h264,hevc", "Container": "mkv", "Conditions": [ { "Condition": "LessThanEqual", "Property": "VideoBitrate", "Value": "10000000", "IsRequired": "true" } ] }, { "Codec": "h264", "Container": "mkv", "Conditions": [ { "Condition": "LessThanEqual", "Property": "VideoLevel", "Value": "42", "IsRequired": "true" } ] } ``` both conditions should apply for `h264` in `mkv`. **Changes** Allow (bring back) a list of codecs in `CodecProfiles` while keeping the idea of #9411. **Issues** N/A

OVERLORD added the pull-request label 2026-02-07 06:51:49 +03:00

OVERLORD closed this issue

2026-02-07 06:51:51 +03:00

Sign in to join this conversation.

Branches Tags

master

renovate/major-skiasharp-monorepo

renovate/sharpcompress-0.x

renovate/svg.skia-5.x

renovate/ghcr.io-devcontainers-features-docker-in-docker-4.x

release-10.11.z

standards-fix

release-10.9.z

openapi-cache

release-10.10.z

explicit-load

explicit-load-v2

feature/entity-framework

only-count-folder-item

fix/ci-workflow-refactor

release-10.8.z

release-10.7.z

EraYaN-add-management-interface

release-10.6.z

release-10.5.z

release-10.4.z

release-10.3.z

release-10.2.z

release-10.1.0

1 Participants

Notifications

Due Date

No due date set.

Dependencies

No dependencies set.

Reference: starred/jellyfin#12203