starred/jellyfin
1
0
Fork 0
mirror of https://github.com/jellyfin/jellyfin.git synced 2026-07-16 05:43:54 +03:00
Code Issues 822 Packages Projects Releases 17 Wiki Activity

[PR #9446] Audiobook grouping fixes #12115

New Issue
Closed
opened 2026-02-07 06:50:15 +03:00 by OVERLORD · 0 comments
OVERLORD commented 2026-02-07 06:50:15 +03:00
Owner
Copy Link

Original Pull Request: https://github.com/jellyfin/jellyfin/pull/9446

State: closed
Merged: Yes

There's logic in place to stack individual audio book files as chapters/parts of a single book. Unfortunately there's not yet any way to actually browse stacked files, so in most cases the file stack is ignored in favor of the directory view.

This PR adds tests and fixes a couple corner cases that should currently be ignored but weren't. There should be fewer cases where file names unexpectedly cause a folder of audio book files to collapse to a single accessible file.

Changes

  • Clean up ItemResolveArgs:
    • remove some BaseItem references
    • refactor IDirectoryService to be injected where used instead of passed around in ItemResolveArgs
  • Add audiobook tests for AudioResolver
  • Fix cases where multiple files unexpectedly resolved into a single file representing the book

Issues
Fixes #9382
Probably fixes #8404 (no directory listings provided to verify)
May fix #7875

**Original Pull Request:** https://github.com/jellyfin/jellyfin/pull/9446 **State:** closed **Merged:** Yes --- There's logic in place to stack individual audio book files as chapters/parts of a single book. Unfortunately there's not yet any way to actually browse stacked files, so in most cases the file stack is ignored in favor of the directory view. This PR adds tests and fixes a couple corner cases that should currently be ignored but weren't. There should be fewer cases where file names unexpectedly cause a folder of audio book files to collapse to a single accessible file. **Changes** - Clean up ItemResolveArgs: - remove some BaseItem references - refactor IDirectoryService to be injected where used instead of passed around in ItemResolveArgs - Add audiobook tests for AudioResolver - Fix cases where multiple files unexpectedly resolved into a single file representing the book **Issues** Fixes #9382 Probably fixes #8404 (no directory listings provided to verify) May fix #7875
OVERLORD added the pull-request label 2026-02-07 06:50:15 +03:00
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
EFjellyfin.db
area:database
awaiting-feedback
backend
blocked
breaking change: web api
bug
build
ci
confirmed
discussion needed
dotnet future
downstream
duplicate
enhancement
feature
future
github-actions
good first issue
hdr
help wanted
invalid
investigation
librarydb
live-tv
lyrics
media playback
music
needs testing
nuget
performance
platform
pull-request
Mirrored from GitHub Pull Request
 question
regression
release critical
requires-web
roadmap
security
security
stale
support
syncplay
ui & ux
upstream
wontfix
No Label pull-request
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
OVERLORD
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: starred/jellyfin#12115
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?