starred/jellyfin
1
0
Fork 0
mirror of https://github.com/jellyfin/jellyfin.git synced 2026-07-16 05:43:54 +03:00
Code Issues 822 Packages Projects Releases 17 Wiki Activity

[PR #8985] Checkout common ancestor for comparison in OpenAPI workflow #11936

New Issue
Closed
opened 2026-02-07 06:47:09 +03:00 by OVERLORD · 0 comments
OVERLORD commented 2026-02-07 06:47:09 +03:00
Owner
Copy Link

Original Pull Request: https://github.com/jellyfin/jellyfin/pull/8985

State: closed
Merged: Yes

Changes
Find the common ancestor between the pull request and it's target branch so we can compare the OpenAPI changes properly. I tested this in my fork and it does seem to work after a bunch of trial and error.

This fixes the problem where once a API-changing PR is merged to master, the workflow would suddenly act like the API changes were reverted in all other PR's because it checked out the latest commit in master instead of the common ancestor.

Issues

**Original Pull Request:** https://github.com/jellyfin/jellyfin/pull/8985 **State:** closed **Merged:** Yes --- **Changes** Find the common ancestor between the pull request and it's target branch so we can compare the OpenAPI changes properly. I tested this in my fork and it does seem to work after a bunch of trial and error. This fixes the problem where once a API-changing PR is merged to master, the workflow would suddenly act like the API changes were reverted in all other PR's because it checked out the latest commit in master instead of the common ancestor. **Issues** <!-- Tag any issues that this PR solves here. ex. Fixes # -->
OVERLORD added the pull-request label 2026-02-07 06:47:09 +03:00
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
EFjellyfin.db
area:database
awaiting-feedback
backend
blocked
breaking change: web api
bug
build
ci
confirmed
discussion needed
dotnet future
downstream
duplicate
enhancement
feature
future
github-actions
good first issue
hdr
help wanted
invalid
investigation
librarydb
live-tv
lyrics
media playback
music
needs testing
nuget
performance
platform
pull-request
Mirrored from GitHub Pull Request
 question
regression
release critical
requires-web
roadmap
security
security
stale
support
syncplay
ui & ux
upstream
wontfix
No Label pull-request
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
OVERLORD
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: starred/jellyfin#11936
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?